* gianfar breaking builds
@ 2009-12-09 6:56 Benjamin Herrenschmidt
2009-12-09 8:50 ` Kumar Gopalpet-B05799
2009-12-09 10:44 ` [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y Anton Vorontsov
0 siblings, 2 replies; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2009-12-09 6:56 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
In my next (not pushed out yet as I'm writing this but will be by the
time you read it hopefully), I get a build failure:
/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In function ‘gfar_netpoll’:
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653: error: invalid storage class for function ‘gfar_interrupt’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652: warning: ISO C90 forbids mixed declarations and code
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681: error: invalid storage class for function ‘adjust_link’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764: error: invalid storage class for function ‘gfar_set_multi’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855: error: invalid storage class for function ‘gfar_clear_exact_match’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877: error: invalid storage class for function ‘gfar_set_hash_for_addr’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898: error: invalid storage class for function ‘gfar_set_mac_for_addr’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922: error: invalid storage class for function ‘gfar_error’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017: warning: ‘alias’ attribute ignored
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032: error: invalid storage class for function ‘gfar_init’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037: error: invalid storage class for function ‘gfar_exit’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041: error: invalid storage class for function ‘__inittest’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041: warning: ‘alias’ attribute ignored
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: error: invalid storage class for function ‘__exittest’
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: warning: ISO C90 forbids mixed declarations and code
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: warning: ‘alias’ attribute ignored
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: error: expected declaration or statement at end of input
make[3]: *** [drivers/net/gianfar.o] Error 1
Stephen says that breakage has been in -next for some time...
Can you guys sort it out ?
Cheers,
Ben.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: gianfar breaking builds
2009-12-09 6:56 gianfar breaking builds Benjamin Herrenschmidt
@ 2009-12-09 8:50 ` Kumar Gopalpet-B05799
2009-12-09 9:26 ` Benjamin Herrenschmidt
2009-12-09 10:44 ` [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y Anton Vorontsov
1 sibling, 1 reply; 8+ messages in thread
From: Kumar Gopalpet-B05799 @ 2009-12-09 8:50 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
Hi Ben,
Can you point to me from where you cloned the tree.
Also, net-next-2.6 tree was building for me.
--
Thanks
Sandeep
>-----Original Message-----
>From:=20
>linuxppc-dev-bounces+sandeep.kumar=3Dfreescale.com@lists.ozlabs.o
>rg=20
>[mailto:linuxppc-dev-bounces+sandeep.kumar=3Dfreescale.com@lists.
>ozlabs.org] On Behalf Of Benjamin Herrenschmidt
>Sent: Wednesday, December 09, 2009 12:27 PM
>To: Kumar Gala
>Cc: linuxppc-dev
>Subject: gianfar breaking builds
>
>In my next (not pushed out yet as I'm writing this but will be=20
>by the time you read it hopefully), I get a build failure:
>
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In=20
>function 'gfar_netpoll':
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653:=20
>error: invalid storage class for function 'gfar_interrupt'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652:=20
>warning: ISO C90 forbids mixed declarations and code
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681:=20
>error: invalid storage class for function 'adjust_link'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764:=20
>error: invalid storage class for function 'gfar_set_multi'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855:=20
>error: invalid storage class for function 'gfar_clear_exact_match'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877:=20
>error: invalid storage class for function 'gfar_set_hash_for_addr'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898:=20
>error: invalid storage class for function 'gfar_set_mac_for_addr'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922:=20
>error: invalid storage class for function 'gfar_error'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017:=20
>warning: 'alias' attribute ignored
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032:=20
>error: invalid storage class for function 'gfar_init'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037:=20
>error: invalid storage class for function 'gfar_exit'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:=20
>error: invalid storage class for function '__inittest'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:=20
>warning: 'alias' attribute ignored
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
>error: invalid storage class for function '__exittest'
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
>warning: ISO C90 forbids mixed declarations and code
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
>warning: 'alias' attribute ignored
>/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
>error: expected declaration or statement at end of input
>make[3]: *** [drivers/net/gianfar.o] Error 1
>
>Stephen says that breakage has been in -next for some time...
>
>Can you guys sort it out ?
>
>Cheers,
>Ben.
>
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: gianfar breaking builds
2009-12-09 8:50 ` Kumar Gopalpet-B05799
@ 2009-12-09 9:26 ` Benjamin Herrenschmidt
2009-12-09 9:32 ` Kumar Gopalpet-B05799
0 siblings, 1 reply; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2009-12-09 9:26 UTC (permalink / raw)
To: Kumar Gopalpet-B05799; +Cc: linuxppc-dev
On Wed, 2009-12-09 at 14:20 +0530, Kumar Gopalpet-B05799 wrote:
> Hi Ben,
>
> Can you point to me from where you cloned the tree.
>
> Also, net-next-2.6 tree was building for me.
This is powerpc-next which contains the current Linus stuff plus the
pending powerpc stuff. If that's fixed in net-next then we shall wait
for Dave to merge it I suppose.
Cheers,
Ben.
> --
> Thanks
> Sandeep
>
> >-----Original Message-----
> >From:
> >linuxppc-dev-bounces+sandeep.kumar=freescale.com@lists.ozlabs.o
> >rg
> >[mailto:linuxppc-dev-bounces+sandeep.kumar=freescale.com@lists.
> >ozlabs.org] On Behalf Of Benjamin Herrenschmidt
> >Sent: Wednesday, December 09, 2009 12:27 PM
> >To: Kumar Gala
> >Cc: linuxppc-dev
> >Subject: gianfar breaking builds
> >
> >In my next (not pushed out yet as I'm writing this but will be
> >by the time you read it hopefully), I get a build failure:
> >
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In
> >function 'gfar_netpoll':
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653:
> >error: invalid storage class for function 'gfar_interrupt'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652:
> >warning: ISO C90 forbids mixed declarations and code
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681:
> >error: invalid storage class for function 'adjust_link'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764:
> >error: invalid storage class for function 'gfar_set_multi'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855:
> >error: invalid storage class for function 'gfar_clear_exact_match'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877:
> >error: invalid storage class for function 'gfar_set_hash_for_addr'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898:
> >error: invalid storage class for function 'gfar_set_mac_for_addr'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922:
> >error: invalid storage class for function 'gfar_error'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017:
> >warning: 'alias' attribute ignored
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032:
> >error: invalid storage class for function 'gfar_init'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037:
> >error: invalid storage class for function 'gfar_exit'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:
> >error: invalid storage class for function '__inittest'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:
> >warning: 'alias' attribute ignored
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
> >error: invalid storage class for function '__exittest'
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
> >warning: ISO C90 forbids mixed declarations and code
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
> >warning: 'alias' attribute ignored
> >/home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
> >error: expected declaration or statement at end of input
> >make[3]: *** [drivers/net/gianfar.o] Error 1
> >
> >Stephen says that breakage has been in -next for some time...
> >
> >Can you guys sort it out ?
> >
> >Cheers,
> >Ben.
> >
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >Linuxppc-dev@lists.ozlabs.org
> >https://lists.ozlabs.org/listinfo/linuxppc-dev
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y
2009-12-09 6:56 gianfar breaking builds Benjamin Herrenschmidt
2009-12-09 8:50 ` Kumar Gopalpet-B05799
@ 2009-12-09 10:44 ` Anton Vorontsov
2009-12-09 10:52 ` David Miller
1 sibling, 1 reply; 8+ messages in thread
From: Anton Vorontsov @ 2009-12-09 10:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Sandeep Gopalpet, netdev, linuxppc-dev, David Miller
commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add
Multiple group Support") introduced the following build error
with CONFIG_NET_POLL_CONTROLLER=y:
CC ggianfar.o
ggianfar.c: In function 'gfar_netpoll':
ggianfar.c:2653: error: invalid storage class for function 'gfar_interrupt'
ggianfar.c:2652: warning: ISO C90 forbids mixed declarations and code
ggianfar.c:2681: error: invalid storage class for function 'adjust_link'
ggianfar.c:2764: error: invalid storage class for function 'gfar_set_multi'
ggianfar.c:2855: error: invalid storage class for function 'gfar_clear_exact_match'
ggianfar.c:2877: error: invalid storage class for function 'gfar_set_hash_for_addr'
ggianfar.c:2898: error: invalid storage class for function 'gfar_set_mac_for_addr'
ggianfar.c:2922: error: invalid storage class for function 'gfar_error'
ggianfar.c:3020: warning: ISO C90 forbids mixed declarations and code
ggianfar.c:3032: error: invalid storage class for function 'gfar_init'
ggianfar.c:3037: error: invalid storage class for function 'gfar_exit'
ggianfar.c:3041: error: initializer element is not constant
ggianfar.c:3042: error: initializer element is not constant
ggianfar.c:3042: warning: ISO C90 forbids mixed declarations and code
ggianfar.c:3042: error: expected declaration or statement at end of input
make[1]: *** [ggianfar.o] Error 1
This patch fixes the issue.
Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
On Wed, Dec 09, 2009 at 05:56:44PM +1100, Benjamin Herrenschmidt wrote:
> In my next (not pushed out yet as I'm writing this but will be by the
> time you read it hopefully), I get a build failure:
>
> /home/benh/linux-powerpc-test/drivers/net/gianfar.c: In function ‘gfar_netpoll’:
> /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653: error: invalid storage class for function ‘gfar_interrupt’
[...]
> make[3]: *** [drivers/net/gianfar.o] Error 1
>
> Stephen says that breakage has been in -next for some time...
>
> Can you guys sort it out ?
drivers/net/gianfar.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 16def13..6850dc0 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -2644,6 +2644,7 @@ static void gfar_netpoll(struct net_device *dev)
gfar_interrupt(priv->gfargrp[i].interruptTransmit,
&priv->gfargrp[i]);
enable_irq(priv->gfargrp[i].interruptTransmit);
+ }
}
}
#endif
--
1.6.3.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y
2009-12-09 10:44 ` [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y Anton Vorontsov
@ 2009-12-09 10:52 ` David Miller
2009-12-09 13:55 ` Kumar Gopalpet-B05799
0 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2009-12-09 10:52 UTC (permalink / raw)
To: avorontsov; +Cc: Sandeep.Kumar, linuxppc-dev, netdev
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Wed, 9 Dec 2009 13:44:27 +0300
> commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add
> Multiple group Support") introduced the following build error
> with CONFIG_NET_POLL_CONTROLLER=y:
...
> This patch fixes the issue.
>
> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, but this shows that netconsole needs some serious
testing with this drive now :-/
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y
2009-12-09 10:52 ` David Miller
@ 2009-12-09 13:55 ` Kumar Gopalpet-B05799
0 siblings, 0 replies; 8+ messages in thread
From: Kumar Gopalpet-B05799 @ 2009-12-09 13:55 UTC (permalink / raw)
To: avorontsov; +Cc: David Miller, linuxppc-dev, netdev
=20
>From: Anton Vorontsov <avorontsov@ru.mvista.com>
>Date: Wed, 9 Dec 2009 13:44:27 +0300
>
>> commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add=20
>> Multiple group Support") introduced the following build error with=20
>> CONFIG_NET_POLL_CONTROLLER=3Dy:
> ...
>> This patch fixes the issue.
>>=20
>> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
Thanks Anton !
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-12-09 13:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-09 6:56 gianfar breaking builds Benjamin Herrenschmidt
2009-12-09 8:50 ` Kumar Gopalpet-B05799
2009-12-09 9:26 ` Benjamin Herrenschmidt
2009-12-09 9:32 ` Kumar Gopalpet-B05799
2009-12-09 9:34 ` Benjamin Herrenschmidt
2009-12-09 10:44 ` [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y Anton Vorontsov
2009-12-09 10:52 ` David Miller
2009-12-09 13:55 ` Kumar Gopalpet-B05799
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).