From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH -tip tracing/kprobes] PPC: Powerpc port of the kprobe-based event tracer
Date: Thu, 17 Dec 2009 18:07:07 +1100 [thread overview]
Message-ID: <1261033627.6682.28.camel@pasglop> (raw)
In-Reply-To: <13884.1261016575@neuling.org>
On Thu, 2009-12-17 at 13:22 +1100, Michael Neuling wrote:
> > + * The @offset is the offset of the register in struct pt_regs.
> > + * If @offset is bigger than MAX_REG_OFFSET, this returns 0.
> > + */
> > +static inline unsigned long regs_get_register(struct pt_regs *regs,
> > + unsigned int offset)
>
> Please put only function definitions in the .h file. The rest of this
> should be in .c
Not really in that case actually. There are just simple accessors, we
traditionally have them in .h files so they get fully inlined when
used.
I'll have a look at the rest of the patch asap, hopefully tomorrow.
Cheers,
Ben.
next prev parent reply other threads:[~2009-12-17 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091216043619.963539987@mars.in.ibm.com>
2009-12-16 4:39 ` [PATCH -tip tracing/kprobes] PPC: Powerpc port of the kprobe-based event tracer Mahesh Salgaonkar
2009-12-17 2:22 ` Michael Neuling
2009-12-17 5:38 ` Masami Hiramatsu
2009-12-17 9:43 ` Michael Neuling
2009-12-17 7:07 ` Benjamin Herrenschmidt [this message]
2009-12-17 8:39 ` Mahesh Jagannath Salgaonkar
2009-12-17 9:57 ` Michael Neuling
2009-12-18 5:10 ` Mahesh Jagannath Salgaonkar
2009-12-18 14:35 ` Masami Hiramatsu
2009-12-20 20:54 ` Michael Neuling
2009-12-23 1:32 ` Masami Hiramatsu
2009-12-23 2:37 ` Michael Neuling
2009-12-20 20:59 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261033627.6682.28.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mhiramat@redhat.com \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).