linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Hamish Guthrie <Hamish.Guthrie@sonycom.com>
Subject: Re: [PATCH v2] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
Date: Sat, 19 Dec 2009 09:09:36 +1100	[thread overview]
Message-ID: <1261174176.2173.67.camel@pasglop> (raw)
In-Reply-To: <4B2BC8E6.9090007@am.sony.com>

On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> The option to support the old style PSK interface in the PS3
> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> v2: Added 'depends on WLAN'.
> 
> Please send to Linus asap (or I can put it in powerpc.git) as it's
> breaking one of my test build configs :-)
> 
> Just as a note, I asked Hamish to work to remove this option.
> No distros use it anymore, so we don't need it.

Geoff, the depends on WLAN should be on config GELIC_WIRELESS

Cheers,
Ben.

> -Geoff
> ---
>  drivers/net/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2357,7 +2357,9 @@ config GELIC_WIRELESS
>  
>  config GELIC_WIRELESS_OLD_PSK_INTERFACE
>         bool "PS3 Wireless private PSK interface (OBSOLETE)"
> +       depends on WLAN
>         depends on GELIC_WIRELESS
> +       select WEXT_PRIV
>         help
>            This option retains the obsolete private interface to pass
>            the PSK from user space programs to the driver.  The PSK

  parent reply	other threads:[~2009-12-18 22:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18  5:52 [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV Benjamin Herrenschmidt
2009-12-18 16:55 ` Randy Dunlap
2009-12-18 18:24   ` [PATCH v2] " Geoff Levand
2009-12-18 18:30     ` Johannes Berg
2009-12-18 19:01       ` Geoff Levand
2009-12-18 22:09     ` Benjamin Herrenschmidt [this message]
2009-12-18 22:09   ` [PATCH] " Benjamin Herrenschmidt
2009-12-18 19:19 ` [PATCH v3] " Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261174176.2173.67.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=Hamish.Guthrie@sonycom.com \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).