Re: [PATCH] of/flattree: use callback to setup initrd from /chosen

Jeremy Kerr
2009-12-22T10:54:37Z

Hi Michael,

> > void early_init_dt_setup_initrd_arch(unsigned long start,
> > unsigned long end);
>
> arch_early_init_dt_setup_initrd() makes more sense to me, but ..

<foo>_arch has been the general convention for arch-specific hooks in
drivers/of/.

> > +#ifdef CONFIG_BLK_DEV_INITRD
> > +void __init early_init_dt_setup_initrd_arch(unsigned long start,
> > + unsigned long end)
> > +{
> > + initrd_start = (unsigned long)__va(start);
> > + initrd_end = (unsigned long)__va(end);
> > + initrd_below_start_ok = 1;
> > +}
> > +#endif
>
> Given you have two identical implementations why not make that the
> default and make it weak, and let ARM override it.

Yeah, that would be good too; just been avoiding weak as a potential source of
magic voodoo complexity. Grant - up to you on this one.

Cheers,

Jeremy