From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linuxppc-dev@ozlabs.org,
"Robert P. J. Day" <rpjday@crashcourse.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
Date: Sat, 02 Jan 2010 08:11:19 +1100 [thread overview]
Message-ID: <1262380279.2173.240.camel@pasglop> (raw)
In-Reply-To: <201001011915.47849.bzolnier@gmail.com>
On Fri, 2010-01-01 at 19:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > no appropriate subsystem maintainer listed in MAINTAINERS.
>
> drivers/char/Makefile:
> obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
>
> so it should belong to:
>
> HYPERVISOR VIRTUAL CONSOLE DRIVER
> L: linuxppc-dev@ozlabs.org
> S: Odd Fixes
> F: drivers/char/hvc_*
>
> [ Though maybe Ben would be willing to pick this one up directly
> as hvsi is PPC specific thingy and patch is obviously correct. ]
Sure, I'll pick that one up.
Cheers,
Ben.
> > diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> > index 793b236..71c0fcd 100644
> > --- a/drivers/char/hvsi.c
> > +++ b/drivers/char/hvsi.c
> > @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> > uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> > unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
> >
> > - while (time_before(end_jiffies, jiffies))
> > + while (time_before(jiffies, end_jiffies))
> > if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> > break;
> > }
>
> --
> Bartlomiej Zolnierkiewicz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2010-01-01 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.1001011226020.24958@localhost>
2010-01-01 18:15 ` [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c Bartlomiej Zolnierkiewicz
2010-01-01 21:11 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262380279.2173.240.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).