linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stef van Os <stef.van.os@Prodrive.nl>
Cc: linuxppc-dev@ozlabs.org, Felix Radensky <felix@embedded-sol.com>,
	Stefan Roese <sr@denx.de>, Feng Kan <fkan@amcc.com>
Subject: Re: [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards
Date: Wed, 13 Jan 2010 10:18:46 +1100	[thread overview]
Message-ID: <1263338326.724.216.camel@pasglop> (raw)
In-Reply-To: <4CD35CD1F8085945B597F80EEC89421303B8AD11@exc01.bk.prodrive.nl>

On Tue, 2010-01-12 at 15:09 +0100, Stef van Os wrote:
> This patch adds type 1 PCI transactions to 4xx PCI code, enabling the
> discovery of
> devices behind a PCI bridge.

Your patch appears word wrapped and whitespace damaged...

I'll fix it up manually this time around but please check your mailer
setup :-)

Cheers,
Ben.
 
> Signed-off-by: Stef van Os <stef.van.os@gmail.com>
> ---
>  arch/powerpc/sysdev/ppc4xx_pci.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/ppc4xx_pci.c
> b/arch/powerpc/sysdev/ppc4xx_pci.c
> index 6ff9d71..370cc1c 100644
> --- a/arch/powerpc/sysdev/ppc4xx_pci.c
> +++ b/arch/powerpc/sysdev/ppc4xx_pci.c
> @@ -363,7 +363,8 @@ static void __init ppc4xx_probe_pci_bridge(struct
> device_node *np)
>         hose->last_busno = bus_range ? bus_range[1] : 0xff;
> 
>         /* Setup config space */
> -       setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> 0);
> +       setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> +                                       PPC_INDIRECT_TYPE_SET_CFG_TYPE);
> 
>         /* Disable all windows */
>         writel(0, reg + PCIL0_PMM0MA);
> @@ -569,7 +570,8 @@ static void __init ppc4xx_probe_pcix_bridge(struct
> device_node *np)
>         hose->last_busno = bus_range ? bus_range[1] : 0xff;
> 
>         /* Setup config space */
> -       setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> 0);
> +       setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> +                                       PPC_INDIRECT_TYPE_SET_CFG_TYPE);
> 
>         /* Disable all windows */
>         writel(0, reg + PCIX0_POM0SA);
> 
> 
> Disclaimer: The information contained in this email, including any attachments is 
> confidential and is for the sole use of the intended recipient(s). Any unauthorized 
> review, use, disclosure or distribution is prohibited. If you are not the intended 
> recipient, please notify the sender immediately by replying to this message and 
> destroy all copies of this message and any attachments.

  reply	other threads:[~2010-01-12 23:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12 14:09 [PATCH] powerpc/4xx: Add support for type 1 pci transactions on 4xx boards Stef van Os
2010-01-12 23:18 ` Benjamin Herrenschmidt [this message]
2010-01-14  4:56   ` Benjamin Herrenschmidt
2010-01-19 22:52     ` Felix Radensky
2010-01-19 22:57       ` Benjamin Herrenschmidt
2010-01-20 11:21         ` Felix Radensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263338326.724.216.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=felix@embedded-sol.com \
    --cc=fkan@amcc.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    --cc=stef.van.os@Prodrive.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).