powerpc: should mem_end be assigned to dt_struct_end in flatten_device

linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed

* powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()?
@ 2010-01-14 23:00 Roel Kluin
  2010-01-15  2:44 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-14 23:00 UTC (permalink / raw)
  To: Paul Mackerras, linuxppc-dev

vi arch/powerpc/kernel/prom_init.c +1961 and note that in
flatten_device_tree() we do a

	RELOC(dt_struct_end) = PAGE_ALIGN(mem_start);

should that maybe be

	RELOC(dt_struct_end) = PAGE_ALIGN(mem_end);

thanks,

Roel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()?
  2010-01-14 23:00 powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()? Roel Kluin
@ 2010-01-15  2:44 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2010-01-15  2:44 UTC (permalink / raw)
  To: Roel Kluin; +Cc: linuxppc-dev, Paul Mackerras

On Fri, 2010-01-15 at 00:00 +0100, Roel Kluin wrote:
> vi arch/powerpc/kernel/prom_init.c +1961 and note that in
> flatten_device_tree() we do a
> 
>         RELOC(dt_struct_end) = PAGE_ALIGN(mem_start);
> 
> should that maybe be
> 
>         RELOC(dt_struct_end) = PAGE_ALIGN(mem_end);
> 

Nope.

mem_start is a "cursor", it moves as things gets pushed into the flat
device-tree blob. We thus snapshot its value after pushing the last bit
of the structure. mem_end is just the max boundary past which we can no
longer push things.

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-15  2:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 23:00 powerpc: should mem_end be assigned to dt_struct_end in flatten_device_tree()? Roel Kluin
2010-01-15  2:44 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).