From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Wim Van Sebroeck <wim@iguana.be>,
uclinux-dist-devel@blackfin.uclinux.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-omap@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH] watchdog_info separation and constify
Date: Tue, 19 Jan 2010 14:36:11 -0800 [thread overview]
Message-ID: <1263940571.18117.86.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20100119221647.GC29306@sirena.org.uk>
On Tue, 2010-01-19 at 22:16 +0000, Mark Brown wrote:
> On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
> > Maybe a standard #define WATCHDOG_NAME <foo>
> > .identity = WATCHGOD_NAME
>
> I don't really see that the indrection via the #define would buy us
> anything?
Maybe not, just a suggestion.
There are already 17 uses though.
It might have some value like DRV_NAME does or
any other frequent #define used in printks or
#include code.
It may be useful standardization prior to or post
some generic watchdog code consolidation.
$ grep -r --include=*.[ch] -Poh "^#define\s*\w+NAME\b" drivers | \
sed -r -e 's/\s+/ /g' | sort | uniq -c | sort -rn | head -10
334 #define DRV_NAME
137 #define DRIVER_NAME
59 #define MODULE_NAME
25 #define DRVNAME
21 #define DRV_MODULE_NAME
18 #define DEVICE_NAME
17 #define WATCHDOG_NAME
15 #define MY_NAME
12 #define BOARD_MAP_NAME
11 #define DSS_SUBSYS_NAME
prev parent reply other threads:[~2010-01-19 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:17 [RFC] [PATCH] watchdog_info separation and constify Wim Van Sebroeck
2010-01-19 21:27 ` Alan Cox
2010-01-19 22:00 ` Wim Van Sebroeck
2010-01-19 21:42 ` Joe Perches
2010-01-19 21:52 ` Mike Frysinger
2010-01-19 22:16 ` Mark Brown
2010-01-19 22:36 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263940571.18117.86.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).