linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stef van Os <stef.van.os@Prodrive.nl>
Cc: linuxppc-dev@ozlabs.org, felix@embedded-sol.com, sr@denx.de,
	fkan@amcc.com, Stef van Os <stef.van.os@gmail.com>
Subject: Re: [PATCH] powerpc/4xx: Add pcix type 1 transactions
Date: Thu, 21 Jan 2010 07:51:36 +1100	[thread overview]
Message-ID: <1264020696.724.546.camel@pasglop> (raw)
In-Reply-To: <1263995979-10954-1-git-send-email-stef.van.os@prodrive.nl>

On Wed, 2010-01-20 at 14:59 +0100, Stef van Os wrote:
> Some of the newer 4xx pci cores don't send PCI type 1 transactions.
> This patch enables type 1 transations for pcix nodes, thus enabling
> devices behind PCI bridges.
> 
> Signed-off-by: Stef van Os <stef.van.os@gmail.com>
> ---

Thanks, I'll send that to Linus after LCA.

Cheers,
Ben.

>  arch/powerpc/sysdev/ppc4xx_pci.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/ppc4xx_pci.c b/arch/powerpc/sysdev/ppc4xx_pci.c
> index 6ff9d71..8aa3302 100644
> --- a/arch/powerpc/sysdev/ppc4xx_pci.c
> +++ b/arch/powerpc/sysdev/ppc4xx_pci.c
> @@ -569,7 +569,8 @@ static void __init ppc4xx_probe_pcix_bridge(struct device_node *np)
>  	hose->last_busno = bus_range ? bus_range[1] : 0xff;
>  
>  	/* Setup config space */
> -	setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4, 0);
> +	setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> +					PPC_INDIRECT_TYPE_SET_CFG_TYPE);
>  
>  	/* Disable all windows */
>  	writel(0, reg + PCIX0_POM0SA);
> -- 
> 1.6.6.267.g5b159
> 
> 
> Disclaimer: The information contained in this email, including any attachments is 
> confidential and is for the sole use of the intended recipient(s). Any unauthorized 
> review, use, disclosure or distribution is prohibited. If you are not the intended 
> recipient, please notify the sender immediately by replying to this message and 
> destroy all copies of this message and any attachments.

      reply	other threads:[~2010-01-20 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 13:59 [PATCH] powerpc/4xx: Add pcix type 1 transactions Stef van Os
2010-01-20 20:51 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264020696.724.546.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=felix@embedded-sol.com \
    --cc=fkan@amcc.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    --cc=stef.van.os@Prodrive.nl \
    --cc=stef.van.os@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).