[PATCH] powerpc/4xx: Add pcix type 1 transactions

[PATCH] powerpc/4xx: Add pcix type 1 transactions

[Stef van Os]

U29tZSBvZiB0aGUgbmV3ZXIgNHh4IHBjaSBjb3JlcyBkb24ndCBzZW5kIFBDSSB0eXBlIDEgdHJh
bnNhY3Rpb25zLg0KVGhpcyBwYXRjaCBlbmFibGVzIHR5cGUgMSB0cmFuc2F0aW9ucyBmb3IgcGNp
eCBub2RlcywgdGh1cyBlbmFibGluZw0KZGV2aWNlcyBiZWhpbmQgUENJIGJyaWRnZXMuDQoNClNp
Z25lZC1vZmYtYnk6IFN0ZWYgdmFuIE9zIDxzdGVmLnZhbi5vc0BnbWFpbC5jb20+DQotLS0NCiBh
cmNoL3Bvd2VycGMvc3lzZGV2L3BwYzR4eF9wY2kuYyB8ICAgIDMgKystDQogMSBmaWxlcyBjaGFu
Z2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9hcmNo
L3Bvd2VycGMvc3lzZGV2L3BwYzR4eF9wY2kuYyBiL2FyY2gvcG93ZXJwYy9zeXNkZXYvcHBjNHh4
X3BjaS5jDQppbmRleCA2ZmY5ZDcxLi44YWEzMzAyIDEwMDY0NA0KLS0tIGEvYXJjaC9wb3dlcnBj
L3N5c2Rldi9wcGM0eHhfcGNpLmMNCisrKyBiL2FyY2gvcG93ZXJwYy9zeXNkZXYvcHBjNHh4X3Bj
aS5jDQpAQCAtNTY5LDcgKzU2OSw4IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcGM0eHhfcHJvYmVf
cGNpeF9icmlkZ2Uoc3RydWN0IGRldmljZV9ub2RlICpucCkNCiAJaG9zZS0+bGFzdF9idXNubyA9
IGJ1c19yYW5nZSA/IGJ1c19yYW5nZVsxXSA6IDB4ZmY7DQogDQogCS8qIFNldHVwIGNvbmZpZyBz
cGFjZSAqLw0KLQlzZXR1cF9pbmRpcmVjdF9wY2koaG9zZSwgcnNyY19jZmcuc3RhcnQsIHJzcmNf
Y2ZnLnN0YXJ0ICsgMHg0LCAwKTsNCisJc2V0dXBfaW5kaXJlY3RfcGNpKGhvc2UsIHJzcmNfY2Zn
LnN0YXJ0LCByc3JjX2NmZy5zdGFydCArIDB4NCwNCisJCQkJCVBQQ19JTkRJUkVDVF9UWVBFX1NF
VF9DRkdfVFlQRSk7DQogDQogCS8qIERpc2FibGUgYWxsIHdpbmRvd3MgKi8NCiAJd3JpdGVsKDAs
IHJlZyArIFBDSVgwX1BPTTBTQSk7DQotLSANCjEuNi42LjI2Ny5nNWIxNTkNCg0KDQpEaXNjbGFp
bWVyOiBUaGUgaW5mb3JtYXRpb24gY29udGFpbmVkIGluIHRoaXMgZW1haWwsIGluY2x1ZGluZyBh
bnkgYXR0YWNobWVudHMgaXMgDQpjb25maWRlbnRpYWwgYW5kIGlzIGZvciB0aGUgc29sZSB1c2Ug
b2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4gQW55IHVuYXV0aG9yaXplZCANCnJldmlldywg
dXNlLCBkaXNjbG9zdXJlIG9yIGRpc3RyaWJ1dGlvbiBpcyBwcm9oaWJpdGVkLiBJZiB5b3UgYXJl
IG5vdCB0aGUgaW50ZW5kZWQgDQpyZWNpcGllbnQsIHBsZWFzZSBub3RpZnkgdGhlIHNlbmRlciBp
bW1lZGlhdGVseSBieSByZXBseWluZyB0byB0aGlzIG1lc3NhZ2UgYW5kIA0KZGVzdHJveSBhbGwg
Y29waWVzIG9mIHRoaXMgbWVzc2FnZSBhbmQgYW55IGF0dGFjaG1lbnRzLg==

Re: [PATCH] powerpc/4xx: Add pcix type 1 transactions

[Benjamin Herrenschmidt]

On Wed, 2010-01-20 at 14:59 +0100, Stef van Os wrote:
> Some of the newer 4xx pci cores don't send PCI type 1 transactions.
> This patch enables type 1 transations for pcix nodes, thus enabling
> devices behind PCI bridges.
> 
> Signed-off-by: Stef van Os <stef.van.os@gmail.com>
> ---

Thanks, I'll send that to Linus after LCA.

Cheers,
Ben.

>  arch/powerpc/sysdev/ppc4xx_pci.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/ppc4xx_pci.c b/arch/powerpc/sysdev/ppc4xx_pci.c
> index 6ff9d71..8aa3302 100644
> --- a/arch/powerpc/sysdev/ppc4xx_pci.c
> +++ b/arch/powerpc/sysdev/ppc4xx_pci.c
> @@ -569,7 +569,8 @@ static void __init ppc4xx_probe_pcix_bridge(struct device_node *np)
>  	hose->last_busno = bus_range ? bus_range[1] : 0xff;
>  
>  	/* Setup config space */
> -	setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4, 0);
> +	setup_indirect_pci(hose, rsrc_cfg.start, rsrc_cfg.start + 0x4,
> +					PPC_INDIRECT_TYPE_SET_CFG_TYPE);
>  
>  	/* Disable all windows */
>  	writel(0, reg + PCIX0_POM0SA);
> -- 
> 1.6.6.267.g5b159
> 
> 
> Disclaimer: The information contained in this email, including any attachments is 
> confidential and is for the sole use of the intended recipient(s). Any unauthorized 
> review, use, disclosure or distribution is prohibited. If you are not the intended 
> recipient, please notify the sender immediately by replying to this message and 
> destroy all copies of this message and any attachments.