linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: bluesmoke-devel@lists.sourceforge.net
Cc: linuxppc-dev@ozlabs.org, djiang@mvista.com
Subject: Re: [PATCH 1/4] edac: Remove unused mpc85xx debug code
Date: Mon, 25 Jan 2010 11:20:13 -0600	[thread overview]
Message-ID: <1264440013.22019.19.camel@localhost.localdomain> (raw)
In-Reply-To: <1258677749-15968-1-git-send-email-ptyser@xes-inc.com>

On Thu, 2009-11-19 at 18:42 -0600, Peter Tyser wrote:
> Some unused, unsupported debug code existed in the mpc85xx EDAC driver
> that resulted in a build failure when CONFIG_EDAC_DEBUG was defined:
> 
>   drivers/edac/mpc85xx_edac.c: In function 'mpc85xx_mc_err_probe':
>   drivers/edac/mpc85xx_edac.c:1031: error: implicit declaration of function 'edac_mc_register_mcidev_debug'
>   drivers/edac/mpc85xx_edac.c:1031: error: 'debug_attr' undeclared (first use in this function)
>   drivers/edac/mpc85xx_edac.c:1031: error: (Each undeclared identifier is reported only once
>   drivers/edac/mpc85xx_edac.c:1031: error: for each function it appears in.)
> 
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>

<snip>

Any chance some of these will be picked up for 2.6.33?

I added Kumar on CC as I'm not sure if these should go through the EDAC
or PPC tree.

1/4 fixes a build error when CONFIG_EDAC_DEBUG is defined and is pretty
trivial.

2/4 fixes a regression which results in ECC detection not working.

3/4 and 4/4 are "improvements", but don't necessarily need to go into
2.6.33.

Best,
Peter

      parent reply	other threads:[~2010-01-25 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20  0:42 [PATCH 1/4] edac: Remove unused mpc85xx debug code Peter Tyser
2009-11-20  0:42 ` [PATCH 2/4] edac: Fix mpc85xx page calculation Peter Tyser
2009-11-20  0:42 ` [PATCH 3/4] edac: Mask mpc85xx ECC syndrome appropriately Peter Tyser
2009-11-20  0:42 ` [PATCH 4/4] edac: Improve SDRAM error reporting for mpc85xx Peter Tyser
2010-01-25 17:20 ` Peter Tyser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264440013.22019.19.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=bluesmoke-devel@lists.sourceforge.net \
    --cc=djiang@mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).