From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: leitao@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org, Linas Vepstas <linasvepstas@gmail.com>
Subject: Re: [PATCH 1/2] eeh: Fixing a bug when pci structure is null
Date: Fri, 29 Jan 2010 11:03:50 +1100 [thread overview]
Message-ID: <1264723430.20211.16.camel@pasglop> (raw)
In-Reply-To: <0642ead63df1b9fdced24750eb0aea940f0408b7.1264617281.git.root@sanx1002.austin.ibm.com>
On Wed, 2010-01-27 at 12:43 -0600, leitao@linux.vnet.ibm.com wrote:
> diff --git a/arch/powerpc/platforms/pseries/eeh_driver.c b/arch/powerpc/platforms/pseries/eeh_driver.c
> index ef8e454..afdddf6 100644
> --- a/arch/powerpc/platforms/pseries/eeh_driver.c
> +++ b/arch/powerpc/platforms/pseries/eeh_driver.c
> @@ -41,6 +41,13 @@ static inline const char * pcid_name (struct pci_dev *pdev)
> return "";
> }
>
> +inline const char *eeh_pci_name(struct pci_dev *pdev)
> +{
> + if (NULL==pdev)
> + return "<null>";
> + return pci_name(pdev);
> +}
> +
Coding style gack ... just make it static inline in the header file.
Cheers,
Ben.
prev parent reply other threads:[~2010-01-29 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 18:43 [PATCH 1/2] eeh: Fixing a bug when pci structure is null leitao
2010-01-27 18:43 ` [PATCH 2/2] eeh: fixing pci_dev dependency leitao
2010-01-29 0:04 ` Benjamin Herrenschmidt
2010-01-29 15:42 ` Linas Vepstas
2010-01-27 19:09 ` [PATCH 1/2] eeh: Fixing a bug when pci structure is null Linas Vepstas
2010-01-29 0:03 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264723430.20211.16.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=leitao@linux.vnet.ibm.com \
--cc=linasvepstas@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).