From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: neilb@suse.de, Trond.Myklebust@netapp.com, bfields@fieldses.org,
linuxppc-dev@ozlabs.org, paulus@samba.org,
Ricardo.Labiaga@netapp.com, rientjes@google.com, mel@csn.ul.ie,
devicetree-discuss@lists.ozlabs.org, akpm@linux-foundation.org,
kamezawa.hiroyu@jp.fujitsu.com, lee.schermerhorn@hp.com,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
miltonm@bga.com, dave@linux.vnet.ibm.com, chuck.lever@oracle.com,
bhalevy@panasas.com, davem@davemloft.net
Subject: Re: [PATCH] nodmask.h: remove macro any_online_node
Date: Mon, 01 Feb 2010 13:05:58 +1100 [thread overview]
Message-ID: <1264989958.8287.13.camel@pasglop> (raw)
In-Reply-To: <201001061624.59118.hartleys@visionengravers.com>
On Wed, 2010-01-06 at 16:24 -0700, H Hartley Sweeten wrote:
> nodmask.h: remove macro any_online_node
>
> The macro any_online_node is prone to producing sparse warnings
> due to the local symbol 'node'. Since all the in-tree users are really
> requesting the first online node (the mask argument is either
> NODE_MASK_ALL or node_online_map) just use the first_online_node
> macro and remove the any_online_node macro since there are no users.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Mel Gorman <mel@csn.ul.ie>
> Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
> Cc: Milton Miller <miltonm@bga.com>
> Cc: Nathan Fontenot <nfont@austin.ibm.com>
> Cc: Geoff Levand <geoffrey.levand@am.sony.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: J. Bruce Fields <bfields@fieldses.org>
> Cc: Neil Brown <neilb@suse.de>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Benny Halevy <bhalevy@panasas.com>
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Cc: Ricardo Labiaga <Ricardo.Labiaga@netapp.com>
Cheers,
Ben.
prev parent reply other threads:[~2010-02-01 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 23:24 [PATCH] nodmask.h: remove macro any_online_node H Hartley Sweeten
2010-01-06 23:51 ` KAMEZAWA Hiroyuki
2010-01-06 23:52 ` David Rientjes
2010-02-01 2:05 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264989958.8287.13.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Ricardo.Labiaga@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=chuck.lever@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hartleys@visionengravers.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=miltonm@bga.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).