* [async_tx-next PATCH 1/2] fsldma: Fix cookie issues
@ 2010-02-22 17:40 Steven J. Magnani
2010-02-25 19:21 ` Ira W. Snyder
0 siblings, 1 reply; 2+ messages in thread
From: Steven J. Magnani @ 2010-02-22 17:40 UTC (permalink / raw)
To: Dan Williams; +Cc: Zhang Wei, linux-kernel, Steven J. Magnani, linuxppc-dev
fsl_dma_tx_submit() only sets the cookie on the first descriptor of a
transaction. It should set the cookie on all.
Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
---
diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
--- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.000000000 -0600
+++ b/drivers/dma/fsldma.c 2010-02-22 11:24:01.000000000 -0600
@@ -362,7 +362,7 @@ static dma_cookie_t fsl_dma_tx_submit(st
if (cookie < 0)
cookie = 1;
- desc->async_tx.cookie = cookie;
+ child->async_tx.cookie = cookie;
}
chan->common.cookie = cookie;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [async_tx-next PATCH 1/2] fsldma: Fix cookie issues
2010-02-22 17:40 [async_tx-next PATCH 1/2] fsldma: Fix cookie issues Steven J. Magnani
@ 2010-02-25 19:21 ` Ira W. Snyder
0 siblings, 0 replies; 2+ messages in thread
From: Ira W. Snyder @ 2010-02-25 19:21 UTC (permalink / raw)
To: Steven J. Magnani; +Cc: Zhang Wei, Dan Williams, linux-kernel, linuxppc-dev
On Mon, Feb 22, 2010 at 11:40:31AM -0600, Steven J. Magnani wrote:
> fsl_dma_tx_submit() only sets the cookie on the first descriptor of a
> transaction. It should set the cookie on all.
>
> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
> ---
> diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> --- a/drivers/dma/fsldma.c 2010-02-22 11:16:36.000000000 -0600
> +++ b/drivers/dma/fsldma.c 2010-02-22 11:24:01.000000000 -0600
> @@ -362,7 +362,7 @@ static dma_cookie_t fsl_dma_tx_submit(st
> if (cookie < 0)
> cookie = 1;
>
> - desc->async_tx.cookie = cookie;
> + child->async_tx.cookie = cookie;
> }
>
> chan->common.cookie = cookie;
>
This looks correct to me. I'm not sure I ever tested the driver with a
chained struct dma_async_tx_descriptor.
Ira
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-25 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-22 17:40 [async_tx-next PATCH 1/2] fsldma: Fix cookie issues Steven J. Magnani
2010-02-25 19:21 ` Ira W. Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).