From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: linuxppc-dev list <Linuxppc-dev@ozlabs.org>
Subject: [PATCH] powerpc/booke: Fix a couple typos in the advanced ptrace code
Date: Tue, 23 Feb 2010 13:43:17 -0600 [thread overview]
Message-ID: <1266954197.11207.20.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <20100208215049.17930.8586.sendpatchset@norville.austin.ibm.com>
powerpc/booke: Fix a couple typos in the advanced ptrace code
Found and fixed a couple typos in the advanced ptrace patches.
(These patches are currently in benh's next tree.)
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <Linuxppc-dev@ozlabs.org>
---
diff --git a/arch/powerpc/include/asm/reg_booke.h
b/arch/powerpc/include/asm/reg_booke.h
index 126cb05..96c2ce8 100644
--- a/arch/powerpc/include/asm/reg_booke.h
+++ b/arch/powerpc/include/asm/reg_booke.h
@@ -421,8 +421,8 @@
/* Bit definitions related to the DBCR2. */
#define DBCR2_DAC1US 0xC0000000 /* Data Addr Cmp 1 Sup/User */
#define DBCR2_DAC1ER 0x30000000 /* Data Addr Cmp 1 Eff/Real */
-#define DBCR2_DAC2US 0x00000000 /* Data Addr Cmp 2 Sup/User */
-#define DBCR2_DAC2ER 0x00000000 /* Data Addr Cmp 2 Eff/Real */
+#define DBCR2_DAC2US 0x0C000000 /* Data Addr Cmp 2 Sup/User */
+#define DBCR2_DAC2ER 0x03000000 /* Data Addr Cmp 2 Eff/Real */
#define DBCR2_DAC12M 0x00800000 /* DAC 1-2 range enable */
#define DBCR2_DAC12MM 0x00400000 /* DAC 1-2 Mask mode*/
#define DBCR2_DAC12MX 0x00C00000 /* DAC 1-2 range eXclusive */
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index d9b0586..0efa2e3 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -1070,7 +1070,7 @@ static int del_dac(struct task_struct *child, int
slot)
child->thread.dvc1 = 0;
#endif
} else if (slot == 2) {
- if (child->thread.dac1 == 0)
+ if (child->thread.dac2 == 0)
return -ENOENT;
#ifdef CONFIG_PPC_ADV_DEBUG_DAC_RANGE
next prev parent reply other threads:[~2010-02-23 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 21:50 [PATCH 00/04] powerpc/booke: Expose advanced debug registers through extended ptrace interface Dave Kleikamp
2010-02-08 21:50 ` [PATCH 01/04] powerpc/booke: Introduce new CONFIG options for advanced debug registers Dave Kleikamp
2010-02-11 3:55 ` David Gibson
2010-02-08 21:51 ` [PATCH 02/04] powerpc: Extended ptrace interface Dave Kleikamp
2010-02-08 21:51 ` [PATCH 04/04] powerpc/booke: Add support for advanced debug registers Dave Kleikamp
2010-02-08 21:53 ` [PATCH 03/04] powerpc/booke: Add definitions " Dave Kleikamp
2010-02-23 19:43 ` Dave Kleikamp [this message]
2010-03-01 14:57 ` [PATCH] powerpc/booke: Fix breakpoint/watchpoint one-shot behavior Dave Kleikamp
2010-03-04 16:52 ` [PATCH] powerpc/booke: Fix a couple typos in the advanced ptrace code Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266954197.11207.20.camel@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=Linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox