From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "*.citrix.com", Issuer "VeriSign Class 3 Secure Server CA - G2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A66C2B7CEE for ; Thu, 11 Mar 2010 05:28:18 +1100 (EST) Subject: Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. From: Ian Campbell To: "Eric W. Biederman" In-Reply-To: References: <1268218524.11737.68547.camel@zakaz.uk.xensource.com> <1268218559-26784-2-git-send-email-ijc@hellion.org.uk> <86802c441003100406t70dd854fx491f0ee9a6fce62b@mail.gmail.com> <1268225473.11737.69196.camel@zakaz.uk.xensource.com> <1268243447.11737.70807.camel@zakaz.uk.xensource.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Wed, 10 Mar 2010 18:28:11 +0000 Message-ID: <1268245691.11261.38.camel@localhost.localdomain> MIME-Version: 1.0 Cc: Jeremy Fitzhardinge , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@ozlabs.org" , Ingo Molnar , Paul Mackerras , "H. Peter Anvin" , Thomas Gleixner , Yinghai Lu List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2010-03-10 at 18:15 +0000, Eric W. Biederman wrote: > Ian Campbell writes: > > > On Wed, 2010-03-10 at 17:42 +0000, Eric W. Biederman wrote: > >> > >> > >> Ian Xen in this sense is simply not x86. irq_cfg is not acpi or > >> ioapic or anything but x86 specific. It has everything to do with > >> having a per cpu vector table of 256 entries and architecturally > >> receiving a vector number when an interrupt is fired. > >> > >> It totally makes sense for Xen to do something different because > >> architecturally it has a completely different irq subsystem. > > > > OK, so that sounds like you would like the same patchset but without the > > irq_cfg renaming? or potentially with renaming to x86_blah instead (I'll > > rework to your preference). > > Currently the renaming really makes it unclear what you are doing and for > some reason the description of the renaming rubbed me the wrong way. Sorry, I started off a bit confused and then totally misunderstood what related to what and I think that came through in the description. I'll respin without the first patch. Ian.