From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: fthain@telegraphics.com.au
Cc: Michael Beardsworth <mbeards2@uoregon.edu>,
monstr@monstr.eu, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, geert@linux-m68k.org,
Nick Savage <nagaten@gmail.com>
Subject: Re: madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool
Date: Fri, 12 Mar 2010 08:45:10 +1100 [thread overview]
Message-ID: <1268343910.22204.710.camel@pasglop> (raw)
In-Reply-To: <alpine.LNX.2.00.1003101428460.4583@nippy.intranet>
On Wed, 2010-03-10 at 14:48 +1100, fthain@telegraphics.com.au wrote:
> On Tue, 9 Mar 2010, Michael Beardsworth wrote:
>
> > - /* If a probe is in progress or we are sleeping, wait for it to complete */
> > + /* If a probe is in progress or we are sleeping, wait until complete */
>
> If you must "fix" what aint broke, please try not to damage it. I'm sorry
> if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is
> misguided.
>
> Maybe I could point out again (I do this periodically) that checkpatch.pl
> is great but code that fails it is NOT always wrong.
>
> "Check patch" is a good idea but "check existing code" is a waste of
> everyone's time.
Amen !
Cheers,
Ben.
prev parent reply other threads:[~2010-03-11 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 22:07 [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <mbeards2@uoregon.edu> Michael Beardsworth
2010-03-10 3:48 ` madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool fthain
2010-03-11 21:45 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268343910.22204.710.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mbeards2@uoregon.edu \
--cc=monstr@monstr.eu \
--cc=nagaten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).