From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-pci@vger.kernel.org,
Felix Radensky <felix@embedded-sol.com>,
Alex Chiang <achiang@hp.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: Problem with PCI bus rescan on 460EX
Date: Mon, 15 Mar 2010 16:46:46 +1100 [thread overview]
Message-ID: <1268632006.2335.10.camel@pasglop> (raw)
In-Reply-To: <4B9DC820.2060100@jp.fujitsu.com>
On Mon, 2010-03-15 at 14:39 +0900, Kenji Kaneshige wrote:
>
> > Yes, with these lines removed bridge memory window is properly
> allocated.
>
> These lines are to prevent updating IO or memory windows when there
> are
> some devices working behind the bridge. So please note that removing
> these lines is just for debugging.
This is not a very good way to do so though. Many firmwares will leave
those enabled even when the bridges -do- have to be reconfigured.
Worse... the code means that the kernel -will- have updated its resource
tree, probably assigned new resources, etc... to those bridges, and thus
to devices underneath them, but will silently fail to actually update
the bridge BARs to match.
This seems like a major bug to me in fact.
Cheers,
Ben.
next prev parent reply other threads:[~2010-03-15 5:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B8E6FA3.70503@embedded-sol.com>
[not found] ` <20100310225100.GB27324@ldl.fc.hp.com>
2010-03-11 7:45 ` Problem with PCI bus rescan on 460EX Felix Radensky
2010-03-11 20:32 ` Benjamin Herrenschmidt
2010-03-11 21:41 ` Felix Radensky
2010-03-11 21:49 ` Benjamin Herrenschmidt
2010-03-11 7:50 ` Felix Radensky
2010-03-12 9:22 ` Kenji Kaneshige
2010-03-12 23:04 ` Felix Radensky
2010-03-15 5:39 ` Kenji Kaneshige
2010-03-15 5:46 ` Benjamin Herrenschmidt [this message]
2010-03-15 5:54 ` Benjamin Herrenschmidt
2010-03-15 6:09 ` Felix Radensky
2010-03-15 9:00 ` Kenji Kaneshige
2010-03-15 11:23 ` Felix Radensky
2010-03-16 5:40 ` Kenji Kaneshige
2010-03-16 8:39 ` Felix Radensky
2010-03-16 21:40 ` Felix Radensky
2010-03-17 1:03 ` Kenji Kaneshige
2010-03-17 7:38 ` Felix Radensky
2010-03-17 7:47 ` Benjamin Herrenschmidt
2010-03-17 7:57 ` Felix Radensky
2010-03-17 23:04 ` Benjamin Herrenschmidt
2010-03-18 0:09 ` Benjamin Herrenschmidt
2010-03-28 9:13 ` Felix Radensky
2010-03-28 9:56 ` Benjamin Herrenschmidt
2010-03-28 13:07 ` Felix Radensky
2010-03-29 0:05 ` Yinghai Lu
2010-03-29 7:01 ` Kenji Kaneshige
2010-03-29 7:35 ` Felix Radensky
2010-03-02 13:27 Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268632006.2335.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=achiang@hp.com \
--cc=felix@embedded-sol.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).