* [PATCH] powerpc/fsl-booke: Get coherent bit from PTE
@ 2010-03-17 4:41 Kumar Gala
2010-03-18 7:02 ` Micha Nelissen
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2010-03-17 4:41 UTC (permalink / raw)
To: linuxppc-dev
We shouldn't be always setting 'M' in the TLB entry since its reasonable
for somethings to be mapped non-coherent. The PTE should have 'M' set
properly.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
arch/powerpc/kernel/head_fsl_booke.S | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 25793bb..a7cf493 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -747,9 +747,6 @@ finish_tlb_load:
#else
rlwimi r12, r11, 26, 27, 31 /* extract WIMGE from pte */
#endif
-#ifdef CONFIG_SMP
- ori r12, r12, MAS2_M
-#endif
mtspr SPRN_MAS2, r12
#ifdef CONFIG_PTE_64BIT
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/fsl-booke: Get coherent bit from PTE
2010-03-17 4:41 [PATCH] powerpc/fsl-booke: Get coherent bit from PTE Kumar Gala
@ 2010-03-18 7:02 ` Micha Nelissen
2010-03-18 7:08 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Micha Nelissen @ 2010-03-18 7:02 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Kumar Gala wrote:
> We shouldn't be always setting 'M' in the TLB entry since its reasonable
> for somethings to be mapped non-coherent. The PTE should have 'M' set
> properly.
properly = not at all? AFAICS the patch only removes the setting of the
bit; so where is that 'M' bit set then?
Micha
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/fsl-booke: Get coherent bit from PTE
2010-03-18 7:02 ` Micha Nelissen
@ 2010-03-18 7:08 ` Kumar Gala
0 siblings, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2010-03-18 7:08 UTC (permalink / raw)
To: Micha Nelissen; +Cc: linuxppc-dev
On Mar 18, 2010, at 2:02 AM, Micha Nelissen wrote:
> Kumar Gala wrote:
>> We shouldn't be always setting 'M' in the TLB entry since its =
reasonable
>> for somethings to be mapped non-coherent. The PTE should have 'M' =
set
>> properly.
>=20
> properly =3D not at all? AFAICS the patch only removes the setting of =
the bit; so where is that 'M' bit set then?
>=20
> Micha
Its set via things like the _PAGE_BASE define in =
arch/powerpc/include/asm/pte-common.h
- k=
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-18 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-17 4:41 [PATCH] powerpc/fsl-booke: Get coherent bit from PTE Kumar Gala
2010-03-18 7:02 ` Micha Nelissen
2010-03-18 7:08 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).