From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: linuxppc-dev@ozlabs.org, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] TPM: Provide a tpm_tis OF driver
Date: Thu, 25 Mar 2010 01:20:41 -0300 [thread overview]
Message-ID: <1269490841.12676.32.camel@blackbox.ibm.com> (raw)
In-Reply-To: <20100309200135.GF30462@obsidianresearch.com>
Just a minor comment
On Tue, 2010-03-09 at 13:01 -0700, Jason Gunthorpe wrote:
> @@ -703,7 +747,17 @@ static int __init init_tis(void)
> return rc;
> }
>
> - return pnp_register_driver(&tis_pnp_driver);
> +#ifdef CONFIG_OF
> + rc = of_register_platform_driver(&tis_of_driver);
> + if (rc)
> + return rc;
> +#endif
> +#ifdef CONFIG_PNP
> + rc = pnp_register_driver(&tis_pnp_driver);
> + if (rc)
> + return rc;
> +#endif
> + return 0;
> }
>
Why not
+#ifdef CONFIG_OF
+ return of_register_platform_driver(&tis_of_driver);
+#elif CONFIG_PNP
+ return pnp_register_driver(&tis_pnp_driver);
+#endif
?
Other than this it looks nice.
Acked-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Thanks,
Rajiv
next prev parent reply other threads:[~2010-03-25 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 20:01 [PATCH] TPM: Provide a tpm_tis OF driver Jason Gunthorpe
2010-03-25 4:20 ` Rajiv Andrade [this message]
2010-03-25 5:23 ` [tpmdd-devel] " Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269490841.12676.32.camel@blackbox.ibm.com \
--to=srajiv@linux.vnet.ibm.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).