From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: gshan <Gavin.Shan@alcatel-lucent.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: spin_lock_irqsave and multi-core
Date: Thu, 01 Apr 2010 13:56:29 +1100 [thread overview]
Message-ID: <1270090589.7101.86.camel@pasglop> (raw)
In-Reply-To: <4BB407F6.3070106@alcatel-lucent.com>
On Thu, 2010-04-01 at 10:41 +0800, gshan wrote:
> One of my private driver need it. I don't know how to do it.
Then your driver is most certainly doing something wrong :-) No driver
needs that. Ever.
What is it trying to do more precisely ? I might be able to explain what
the right approach is if you can tell me what the driver is trying to
disable all system IRQs for ? Keep in mind that local_irq_save() does a
lot more than just masking external interrupts from your device. It
masks them from -all- devices, including timer interrupts, perfmon
interrupts, etc... Doing so on all cores is generally a big no-no and
almost never really necessary.
Cheers,
Ben.
next prev parent reply other threads:[~2010-04-01 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 1:59 spin_lock_irqsave and multi-core gshan
2010-04-01 2:39 ` Benjamin Herrenschmidt
2010-04-01 2:41 ` gshan
2010-04-01 2:56 ` Benjamin Herrenschmidt [this message]
2010-04-01 3:18 ` gshan
2010-04-01 4:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270090589.7101.86.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Gavin.Shan@alcatel-lucent.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).