From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-i2c@vger.kernel.org
Cc: linuxppc-dev@ozlabs.org, Ben Dooks <ben-linux@fluff.org>
Subject: [PATCH RESEND 2/3] i2c/cpm: drop NO_IRQ
Date: Fri, 2 Apr 2010 02:17:00 +0200 [thread overview]
Message-ID: <1270167421-5205-3-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1270167421-5205-1-git-send-email-w.sang@pengutronix.de>
Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
(http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is
only used on powerpc, where NO_IRQ is 0 anyhow.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Jochen Friedrich <jochen@scram.de>
Cc: Ben Dooks <ben-linux@fluff.org>
---
drivers/i2c/busses/i2c-cpm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index 9c2e100..16948db 100644
--- a/drivers/i2c/busses/i2c-cpm.c
+++ b/drivers/i2c/busses/i2c-cpm.c
@@ -441,7 +441,7 @@ static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)
init_waitqueue_head(&cpm->i2c_wait);
cpm->irq = of_irq_to_resource(ofdev->node, 0, NULL);
- if (cpm->irq == NO_IRQ)
+ if (!cpm->irq)
return -EINVAL;
/* Install interrupt handler. */
--
1.7.0
next prev parent reply other threads:[~2010-04-02 0:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 0:16 Delete NO_IRQ usage from I2C subsystem Wolfram Sang
2010-04-02 0:16 ` [PATCH RESEND 1/3] i2c/mpc: drop NO_IRQ Wolfram Sang
2010-04-02 0:17 ` Wolfram Sang [this message]
2010-04-02 11:34 ` [PATCH RESEND 2/3] i2c/cpm: " Jochen Friedrich
2010-04-02 0:17 ` [PATCH RESEND 3/3] i2c/ibm-iic: " Wolfram Sang
2010-04-02 19:47 ` Sean MacLennan
2010-04-27 7:06 ` Benjamin Herrenschmidt
2010-04-27 7:12 ` Wolfram Sang
2010-04-27 7:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270167421-5205-3-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).