From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: d binderman <dcb314@hotmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: powermac/low_i2c.c: three minor problems
Date: Wed, 07 Apr 2010 14:23:17 +1000 [thread overview]
Message-ID: <1270614197.13812.123.camel@pasglop> (raw)
In-Reply-To: <BLU108-W1270106CF117770B0ABB269C530@phx.gbl>
On Sat, 2010-02-06 at 12:13 +0000, d binderman wrote:
>
> Hello there,
>
> I just ran the sourceforge tool cppcheck over the source code of the
> new Linux kernel 2.6.33-rc6
Hi !
All your patches have various problems with the actual patch format.
Patches should be submitted so that they apply with patch -p1, yours
don't. In fact, the base directory you diffed from seems to differ from
patch to patch. I'm manually fixing those this time around, but please
get that sorted out before you submit a new batch.
Cheers,
Ben.
> It said
>
> [./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable chans can be reduced
> [./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable i can be reduced
> [./arch/powerpc/platforms/powermac/low_i2c.c:1260]: (style) Redundant condition. It is safe to deallocate a NULL pointer
>
> Please find attached a patch to fix these minor problems.
> The patched version compiles, but I have not been able to test it at run time.
>
> Regards
>
> David Binderman
>
> _________________________________________________________________
> Do you have a story that started on Hotmail? Tell us now
> http://clk.atdmt.com/UKM/go/195013117/direct/01/
prev parent reply other threads:[~2010-04-07 4:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 12:13 powermac/low_i2c.c: three minor problems d binderman
2010-04-07 4:23 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270614197.13812.123.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dcb314@hotmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).