From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A2E43B7D5F for ; Wed, 7 Apr 2010 14:23:24 +1000 (EST) Subject: Re: powermac/low_i2c.c: three minor problems From: Benjamin Herrenschmidt To: d binderman In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 07 Apr 2010 14:23:17 +1000 Message-ID: <1270614197.13812.123.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2010-02-06 at 12:13 +0000, d binderman wrote: > > Hello there, > > I just ran the sourceforge tool cppcheck over the source code of the > new Linux kernel 2.6.33-rc6 Hi ! All your patches have various problems with the actual patch format. Patches should be submitted so that they apply with patch -p1, yours don't. In fact, the base directory you diffed from seems to differ from patch to patch. I'm manually fixing those this time around, but please get that sorted out before you submit a new batch. Cheers, Ben. > It said > > [./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable chans can be reduced > [./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable i can be reduced > [./arch/powerpc/platforms/powermac/low_i2c.c:1260]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > Please find attached a patch to fix these minor problems. > The patched version compiles, but I have not been able to test it at run time. > > Regards > > David Binderman > > _________________________________________________________________ > Do you have a story that started on Hotmail? Tell us now > http://clk.atdmt.com/UKM/go/195013117/direct/01/