From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: svaidy@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [RFC] powerpc: add support for new hcall H_BEST_ENERGY
Date: Wed, 07 Apr 2010 15:13:38 +1000 [thread overview]
Message-ID: <1270617218.2300.1.camel@pasglop> (raw)
In-Reply-To: <20100407045718.GA14391@dirshya.in.ibm.com>
On Wed, 2010-04-07 at 10:27 +0530, Vaidyanathan Srinivasan wrote:
> > Check the result. Also that's not a nice way to do that, you should look
> > for /cpus by path I reckon.
>
> I will check the return code, but why do you feel getting the node by
> path is better? Is there any race, or we may have duplicate "cpus"
> node?
Well, you never really know what might be down the device-tree :-) /cpus
is well defined where it is, while god knows what would happen if
somebody had the weird idea to have something called "cpus" below some
device driver for whatever reason they might even.
Cheers,
Ben.
prev parent reply other threads:[~2010-04-07 5:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 18:18 [RFC] powerpc: add support for new hcall H_BEST_ENERGY Vaidyanathan Srinivasan
2010-03-05 19:18 ` Dipankar Sarma
2010-03-08 6:50 ` Vaidyanathan Srinivasan
2010-03-08 19:28 ` Dipankar Sarma
2010-03-10 4:30 ` Vaidyanathan Srinivasan
2010-04-07 2:04 ` Benjamin Herrenschmidt
2010-04-07 4:57 ` Vaidyanathan Srinivasan
2010-04-07 5:13 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270617218.2300.1.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox