From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Vorontsov <avorontsov@mvista.com>
Cc: linuxppc-dev@ozlabs.org, Wim Van Sebroeck <wim@iguana.be>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] booke_wdt: Fix build (unconstify watchdog_info)
Date: Tue, 27 Apr 2010 16:37:00 +1000 [thread overview]
Message-ID: <1272350220.24542.7.camel@pasglop> (raw)
In-Reply-To: <20100426174358.GA16889@oksana.dev.rtsoft.ru>
On Mon, 2010-04-26 at 21:43 +0400, Anton Vorontsov wrote:
> commit 42747d712de56cf2087b702d2ad90af114c53138 ("[WATCHDOG]
> watchdog_info constify") introduced the following build failure:
>
> CC booke_wdt.o
> booke_wdt.c: In function 'booke_wdt_init':
> booke_wdt.c:220: error: assignment of read-only variable 'ident'
>
> Fix this by removing 'const' qualifier from watchdog_info struct.
Should this go via powerpc.git ? If yes, I'll send to Linus asap.
Cheers,
Ben.
> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> ---
> drivers/watchdog/booke_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-
>
> diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wdt.c
> index 500d383..801ead1 100644
> --- a/drivers/watchdog/booke_wdt.c
> +++ b/drivers/watchdog/booke_wdt.c
> @@ -121,7 +121,7 @@ static ssize_t booke_wdt_write(struct file *file, const char __user *buf,
> return count;
> }
>
> -static const struct watchdog_info ident = {
> +static struct watchdog_info ident = {
> .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> .identity = "PowerPC Book-E Watchdog",
> };
next prev parent reply other threads:[~2010-04-27 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 17:43 [PATCH] booke_wdt: Fix build (unconstify watchdog_info) Anton Vorontsov
2010-04-27 6:37 ` Benjamin Herrenschmidt [this message]
2010-04-27 7:42 ` Wim Van Sebroeck
2010-04-27 7:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272350220.24542.7.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).