* [PATCH] mpc5121_nfc: Changed SVR check to allow MPC5123.
@ 2010-04-28 22:33 Steve Deiters
2010-05-04 13:47 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Steve Deiters @ 2010-04-28 22:33 UTC (permalink / raw)
To: linux-mtd, linuxppc-dev
The revision in SVR for MPC5123 is 3. The NFC is the same as MPC5121
revision 2.
---
drivers/mtd/nand/mpc5121_nfc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c
b/drivers/mtd/nand/mpc5121_nfc.c
index 191bf99..dc04d74 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -666,10 +666,10 @@ static int __devinit mpc5121_nfc_probe(struct
of_device *op,
=20
/*
* Check SoC revision. This driver supports only NFC
- * in MPC5121 revision 2.
+ * in MPC5121 revision 2 and MPC5123 revision 3.
*/
rev =3D (mfspr(SPRN_SVR) >> 4) & 0xF;
- if (rev !=3D 2) {
+ if ((rev !=3D 2) && (rev !=3D 3)) {
dev_err(dev, "SoC revision %u is not supported!\n",
rev);
return -ENXIO;
}
--=20
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mpc5121_nfc: Changed SVR check to allow MPC5123.
2010-04-28 22:33 [PATCH] mpc5121_nfc: Changed SVR check to allow MPC5123 Steve Deiters
@ 2010-05-04 13:47 ` Artem Bityutskiy
2010-05-05 18:48 ` [PATCH resend] " Steve Deiters
0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2010-05-04 13:47 UTC (permalink / raw)
To: Steve Deiters; +Cc: linuxppc-dev, linux-mtd
On Wed, 2010-04-28 at 17:33 -0500, Steve Deiters wrote:
> The revision in SVR for MPC5123 is 3. The NFC is the same as MPC5121
> revision 2.
>
> ---
> drivers/mtd/nand/mpc5121_nfc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Please, add your Signed-off-by and re-send.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH resend] mpc5121_nfc: Changed SVR check to allow MPC5123.
2010-05-04 13:47 ` Artem Bityutskiy
@ 2010-05-05 18:48 ` Steve Deiters
2010-05-06 6:42 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Steve Deiters @ 2010-05-05 18:48 UTC (permalink / raw)
To: dedekind1; +Cc: linuxppc-dev, linux-mtd
The revision in SVR for MPC5123 is 3. The NFC is the same as MPC5121
revision 2.
Signed-off-by: Steve Deiters <SteveDeiters@basler.com>
---
drivers/mtd/nand/mpc5121_nfc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c
b/drivers/mtd/nand/mpc5121_nfc.c
index 191bf99..dc04d74 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -666,10 +666,10 @@ static int __devinit mpc5121_nfc_probe(struct
of_device *op,
=20
/*
* Check SoC revision. This driver supports only NFC
- * in MPC5121 revision 2.
+ * in MPC5121 revision 2 and MPC5123 revision 3.
*/
rev =3D (mfspr(SPRN_SVR) >> 4) & 0xF;
- if (rev !=3D 2) {
+ if ((rev !=3D 2) && (rev !=3D 3)) {
dev_err(dev, "SoC revision %u is not supported!\n",
rev);
return -ENXIO;
}
--=20
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH resend] mpc5121_nfc: Changed SVR check to allow MPC5123.
2010-05-05 18:48 ` [PATCH resend] " Steve Deiters
@ 2010-05-06 6:42 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-05-06 6:42 UTC (permalink / raw)
To: Steve Deiters; +Cc: linuxppc-dev, linux-mtd
On Wed, 2010-05-05 at 13:48 -0500, Steve Deiters wrote:
> The revision in SVR for MPC5123 is 3. The NFC is the same as MPC5121
> revision 2.
>
> Signed-off-by: Steve Deiters <SteveDeiters@basler.com>
> ---
> drivers/mtd/nand/mpc5121_nfc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/mpc5121_nfc.c
> b/drivers/mtd/nand/mpc5121_nfc.c
> index 191bf99..dc04d74 100644
> --- a/drivers/mtd/nand/mpc5121_nfc.c
> +++ b/drivers/mtd/nand/mpc5121_nfc.c
> @@ -666,10 +666,10 @@ static int __devinit mpc5121_nfc_probe(struct
> of_device *op,
>
> /*
> * Check SoC revision. This driver supports only NFC
> - * in MPC5121 revision 2.
> + * in MPC5121 revision 2 and MPC5123 revision 3.
> */
> rev = (mfspr(SPRN_SVR) >> 4) & 0xF;
> - if (rev != 2) {
> + if ((rev != 2) && (rev != 3)) {
> dev_err(dev, "SoC revision %u is not supported!\n",
> rev);
> return -ENXIO;
> }
Now your patch is line-wrapped. But I fixed it and pushed to
l2-mtd-2.6.git / master.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-06 6:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-28 22:33 [PATCH] mpc5121_nfc: Changed SVR check to allow MPC5123 Steve Deiters
2010-05-04 13:47 ` Artem Bityutskiy
2010-05-05 18:48 ` [PATCH resend] " Steve Deiters
2010-05-06 6:42 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).