From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Jin Qing <b24347@freescale.com>
Subject: Re: [PATCH] pte_fsl_booke: fix instruction TLB error permission check
Date: Fri, 14 May 2010 13:36:15 +1000 [thread overview]
Message-ID: <1273808175.21352.481.camel@pasglop> (raw)
In-Reply-To: <0710E9DF-66DF-4D24-95DE-A04E6D869826@kernel.crashing.org>
On Thu, 2010-05-13 at 14:14 -0500, Kumar Gala wrote:
> On May 7, 2010, at 3:38 AM, Li Yang wrote:
>
> > Check the user/supervisor execution permission base on the code address.
> > This fixes the following oops on module loading or removing.
> >
> > Unable to handle kernel paging request for instruction fetch
> > Faulting instruction address: 0xf938d040
> > Oops: Kernel access of bad area, sig: 11 [#1]
> >
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > Signed-off-by: Jin Qing <b24347@freescale.com>
> > ---
> > arch/powerpc/kernel/head_fsl_booke.S | 13 ++++++++++---
> > 1 files changed, 10 insertions(+), 3 deletions(-)
>
> applied to merge.
>
> I've updated the commit message to be a bit more clear on why we need to do this.
>
> Thanks for figuring this out.
Should I pull & send to Linus ?
Cheers,
Ben.
next prev parent reply other threads:[~2010-05-14 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 8:38 [PATCH] pte_fsl_booke: fix instruction TLB error permission check Li Yang
2010-05-13 19:14 ` Kumar Gala
2010-05-13 21:46 ` Benjamin Herrenschmidt
2010-05-14 2:16 ` Liu Dave-R63238
2010-05-14 9:08 ` Benjamin Herrenschmidt
2010-05-14 9:14 ` Liu Dave-R63238
2010-05-14 9:25 ` Benjamin Herrenschmidt
2010-05-14 0:53 ` Liu Dave-R63238
2010-05-14 3:42 ` Benjamin Herrenschmidt
2010-05-14 3:36 ` Benjamin Herrenschmidt [this message]
2010-05-14 4:19 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273808175.21352.481.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=b24347@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).