From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Liu Dave-R63238 <r63238@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Jin Qing-B24347 <B24347@freescale.com>
Subject: RE: [PATCH] pte_fsl_booke: fix instruction TLB error permission check
Date: Fri, 14 May 2010 19:25:21 +1000 [thread overview]
Message-ID: <1273829121.21352.605.camel@pasglop> (raw)
In-Reply-To: <D7CCA83BB0796C49BC0BB53B6AB12089B975F5@zch01exm21.fsl.freescale.net>
On Fri, 2010-05-14 at 17:14 +0800, Liu Dave-R63238 wrote:
> > > Aaron pointed the issue on FSL BookE.
> > >
> > http://lists.ozlabs.org/pipermail/linuxppc-dev/2010-January/079738.htm
> > > l
> >
> > Right, but I think 64-bit BookE has the same issue. We can
> > fix that later tho.
>
> Ben,
>
> We also find the _PAGE_USER is different between pte-book3e and old
> fsl-booke
> It is UR in old fsl-booke, and is _PAGE_BAP_UR | _PAGE_BAP_SR in
> pte-book3e,
> which will cause the ioremap_flags issue.
>
> Did you have a test your commit
> [ea3cc330ac0cd521ff07c7cd432a1848c19a7e92]?
I tested on some things :-) I keep asking Kumar to send me some e500
gear so I can actually test on it :-)
Cheers,
Ben.
next prev parent reply other threads:[~2010-05-14 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 8:38 [PATCH] pte_fsl_booke: fix instruction TLB error permission check Li Yang
2010-05-13 19:14 ` Kumar Gala
2010-05-13 21:46 ` Benjamin Herrenschmidt
2010-05-14 2:16 ` Liu Dave-R63238
2010-05-14 9:08 ` Benjamin Herrenschmidt
2010-05-14 9:14 ` Liu Dave-R63238
2010-05-14 9:25 ` Benjamin Herrenschmidt [this message]
2010-05-14 0:53 ` Liu Dave-R63238
2010-05-14 3:42 ` Benjamin Herrenschmidt
2010-05-14 3:36 ` Benjamin Herrenschmidt
2010-05-14 4:19 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273829121.21352.605.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B24347@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=r63238@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).