linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Darren Hart <dvhltc@us.ibm.com>,
	Jan-Bernd Themann <themann@de.ibm.com>,
	dvhltc@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	Will Schmidt <will_schmidt@vnet.ibm.com>,
	Brian King <brking@linux.vnet.ibm.com>,
	niv@linux.vnet.ibm.com, Doug Maxey <doug.maxey@us.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)
Date: Thu, 20 May 2010 11:34:08 +1000	[thread overview]
Message-ID: <1274319248.22892.40.camel@concordia> (raw)
In-Reply-To: <alpine.LFD.2.00.1005192244430.3368@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote:
> On Wed, 19 May 2010, Thomas Gleixner wrote:
> > > I'm still not clear on why the ultimate solution wasn't to have XICS report
> > > edge triggered as edge triggered. Probably some complexity of the entire power
> > > stack that I am ignorant of.
> > > 
> > > > Apart from the issue of loosing interrupts there is also the fact that
> > > > masking on the XICS requires an RTAS call which takes a global lock.
> > 
> > Right, I'd love to avoid that but with real level interrupts we'd run
> > into an interrupt storm. Though another solution would be to issue the
> > EOI after the threaded handler finished, that'd work as well, but
> > needs testing.
> 
> Thought more about that. The case at hand (ehea) is nasty:
> 
> The driver does _NOT_ disable the rx interrupt in the card in the rx
> interrupt handler - for whatever reason.

Yeah I saw that, but I don't know why it's written that way. Perhaps
Jan-Bernd or Doug will chime in and enlighten us? :)

cheers



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2010-05-20  1:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4BF30793.5070300@us.ibm.com>
2010-05-18 21:52 ` [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY) Brian King
2010-05-18 22:19   ` Nivedita Singhvi
2010-05-18 22:22   ` Darren Hart
2010-05-19  1:25     ` Michael Ellerman
2010-05-19 14:16       ` Darren Hart
2010-05-19 14:38         ` Thomas Gleixner
2010-05-19 21:08           ` Thomas Gleixner
2010-05-20  1:34             ` Michael Ellerman [this message]
2010-05-20  7:37               ` Jan-Bernd Themann
2010-05-20  8:14                 ` Thomas Gleixner
2010-05-20  9:05                   ` Jan-Bernd Themann
2010-05-20  9:19                     ` Thomas Gleixner
2010-05-20 14:26                       ` Nivedita Singhvi
2010-05-20 14:53                     ` Will Schmidt
2010-05-20 14:39                   ` Darren Hart
2010-05-20 14:45                     ` Thomas Gleixner
2010-05-20 21:44                       ` Will Schmidt
2010-05-20  1:32           ` Michael Ellerman
2010-05-20  8:21             ` Thomas Gleixner
2010-05-21  9:18               ` [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY), " Milton Miller
2010-09-20 14:26                 ` Jan-Bernd Themann
2010-05-20  1:28         ` Michael Ellerman
2010-05-21  9:02           ` Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274319248.22892.40.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=brking@linux.vnet.ibm.com \
    --cc=doug.maxey@us.ibm.com \
    --cc=dvhltc@linux.vnet.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=niv@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=themann@de.ibm.com \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).