From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4EEE6B7D1A for ; Sat, 29 May 2010 13:36:06 +1000 (EST) Subject: Re: [PATCH v3] powerpc: Add i8042 keyboard and mouse irq parsing From: Benjamin Herrenschmidt To: Grant Likely In-Reply-To: References: <20100525080834.29149.70967.stgit@ES-J7S4D2J.amer.consind.ge.com> Content-Type: text/plain; charset="UTF-8" Date: Sat, 29 May 2010 13:35:53 +1000 Message-ID: <1275104153.1931.522.camel@pasglop> Mime-Version: 1.0 Cc: Martyn Welch , linuxppc-dev@ozlabs.org, devicetree-discuss , Dmitry Torokhov , linux-input@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > The patch looks okay to me. > > BTW, where is the i8042 binding documented? Ben, is this location of > the kbd/mouse irq historical, or is it just something that we happened > to get when the .dts files were first created? Having the irq > specified directly in the kbd or aux nodes would make a lot more > sense, and if this isn't something already nailed down, then it > probably does make sense to move the irq specification, fall back to > the parent node to still support older trees, and with the hard coded > irq numbers as the last resort. That's just ISA crap. It should be in the existing OF bindings. Cheers, Ben.