From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Esben Haabendal <eha@doredevelopment.dk>
Subject: Re: [PATCH 1/2] powerpc: ipic: use set_irq_chip to ensure irq_chip defaults are applied
Date: Mon, 07 Jun 2010 21:41:05 +1000 [thread overview]
Message-ID: <1275910865.31303.451.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.1006071209140.2933@localhost.localdomain>
On Mon, 2010-06-07 at 12:22 +0200, Thomas Gleixner wrote:
> > Would it be better to change the call order in __setup_irq(), and
> > call irq_chip_set_defaults after __irq_set_trigger() ? Or perhaps
> > even calling it twice (again after __irq_set_trigger()) ?
>
> Grmpf, set_type() was never meant to change the chip. It's fatal do
> so, as the code in setup_irq already has a reference to desc->chip and
> calls the wrong functions anyway aside of having not run through the
> set defaults code.
>
> That needs more thought, as it requires to reload the reference.
>
> Ben, any thoughts ?
Not off hand. It's common to have a different chip ops for different
types, so we need to sort that out. I'll try to have a look asap but I'm
really really swamped at the moment, so I can make no promise that I'll
come up with a solution tomorrow.
/me off to bed
Cheers,
Ben.
next prev parent reply other threads:[~2010-06-07 11:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1275686504.git.eha@doredevelopment.dk>
2010-06-04 21:25 ` [PATCH 1/2] powerpc: ipic: use set_irq_chip to ensure irq_chip defaults are applied Esben Haabendal
2010-06-06 23:45 ` Thomas Gleixner
2010-06-07 5:06 ` Esben Haabendal
2010-06-07 10:22 ` Thomas Gleixner
2010-06-07 11:41 ` Benjamin Herrenschmidt [this message]
2010-06-04 21:25 ` [PATCH 2/2] gpio: pca953x: add powerpc irq support Esben Haabendal
2010-06-06 23:39 ` Thomas Gleixner
2010-06-07 5:50 ` Esben Haabendal
2010-06-07 10:30 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275910865.31303.451.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=eha@doredevelopment.dk \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).