From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7E5CDB7D40 for ; Mon, 7 Jun 2010 21:41:25 +1000 (EST) Subject: Re: [PATCH 1/2] powerpc: ipic: use set_irq_chip to ensure irq_chip defaults are applied From: Benjamin Herrenschmidt To: Thomas Gleixner In-Reply-To: References: <1275686717.2970.13.camel@eha.doredevelopment.dk> <1275887175.2970.20.camel@eha.doredevelopment.dk> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Jun 2010 21:41:05 +1000 Message-ID: <1275910865.31303.451.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev , Esben Haabendal List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2010-06-07 at 12:22 +0200, Thomas Gleixner wrote: > > Would it be better to change the call order in __setup_irq(), and > > call irq_chip_set_defaults after __irq_set_trigger() ? Or perhaps > > even calling it twice (again after __irq_set_trigger()) ? > > Grmpf, set_type() was never meant to change the chip. It's fatal do > so, as the code in setup_irq already has a reference to desc->chip and > calls the wrong functions anyway aside of having not run through the > set defaults code. > > That needs more thought, as it requires to reload the reference. > > Ben, any thoughts ? Not off hand. It's common to have a different chip ops for different types, so we need to sort that out. I'll try to have a look asap but I'm really really swamped at the moment, so I can make no promise that I'll come up with a solution tomorrow. /me off to bed Cheers, Ben.