From: Esben Haabendal <eha@doredevelopment.dk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: joachim.eastwood@jotron.com,
Esben Haabendal <esbenhaabendal@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Marc Zyngier <maz@misterjones.org>,
Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>
Subject: Re: [RFC][PATCH] irq: support IRQ_NESTED_THREAD with non-threaded interrupt handlers
Date: Tue, 08 Jun 2010 09:23:40 +0200 [thread overview]
Message-ID: <1275981820.2870.74.camel@eha.doredevelopment.dk> (raw)
In-Reply-To: <alpine.LFD.2.00.1006080853220.2933@localhost.localdomain>
On Tue, 2010-06-08 at 08:58 +0200, Thomas Gleixner wrote:
> On Mon, 7 Jun 2010, Esben Haabendal wrote:
>
> > On Mon, Jun 7, 2010 at 5:06 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > > Maybe you understand now, why I was pretty sure upfront, that your
> > > approach was wrong even without knowing all the gory details ? :)
> >
> > I understand. There is a better solution, which is to use threaded
> > interrupts where needed.
>
> FWIW, it just occured to me, that the only reason why the
> disable_irq_nosysnc() trips up on the in_atomic() check is your
> fiddling with the nested irq dispatcher.
>
> If you just would have changed the phy driver to
> request_irq_any_context() it would have simply worked out of the box,
> without any need to remove buslock and changing genirq code at all.
>
> That would not give you the advantage of getting rid of the two
> additional I2C transfers, but that's nn optimzation not a functional
> requirement.
Now, that is good news. Thanks!
/Esben
prev parent reply other threads:[~2010-06-08 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1275686352.2970.2.camel@eha.doredevelopment.dk>
[not found] ` <alpine.LFD.2.00.1006042343150.2933@localhost.localdomain>
[not found] ` <AANLkTilb7---Qg1oLwzanKP1RGe04fkAXDtZzz0w9MGz@mail.gmail.com>
[not found] ` <20100605151031.2d562268@hina.wild-wind.fr.eu.org>
[not found] ` <alpine.LFD.2.00.1006051732270.2933@localhost.localdomain>
[not found] ` <AANLkTimlSBEhl58CNuScKjxbqdTwTYgqo7vrHTcd1x9G@mail.gmail.com>
[not found] ` <alpine.LFD.2.00.1006051915290.2933@localhost.localdomain>
[not found] ` <AANLkTimcB9vRqnNYyBh6hjHXZHcmFvw72MZUEIGfeexq@mail.gmail.com>
[not found] ` <alpine.LFD.2.00.1006052155100.2933@localhost.localdomain>
[not found] ` <AANLkTik2so7osQJFq6NRaIFK2GVLURVozOqSsejd1K0F@mail.gmail.com>
[not found] ` <alpine.LFD.2.00.1006062228120.2933@localhost.localdomain>
2010-06-07 12:34 ` [RFC][PATCH] irq: support IRQ_NESTED_THREAD with non-threaded interrupt handlers Esben Haabendal
2010-06-07 15:06 ` Thomas Gleixner
2010-06-07 21:28 ` Esben Haabendal
2010-06-07 23:18 ` Thomas Gleixner
2010-06-08 14:15 ` Esben Haabendal
2010-06-08 6:58 ` Thomas Gleixner
2010-06-08 7:23 ` Esben Haabendal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275981820.2870.74.camel@eha.doredevelopment.dk \
--to=eha@doredevelopment.dk \
--cc=davem@davemloft.net \
--cc=esbenhaabendal@gmail.com \
--cc=joachim.eastwood@jotron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maz@misterjones.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).