From: Steve Best <sfbest@us.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Fix integer constant warning
Date: Wed, 09 Jun 2010 07:50:07 -0400 [thread overview]
Message-ID: <1276084207.6135.11.camel@localhost.localdomain> (raw)
In-Reply-To: <9000.1276002746@redhat.com>
On Tue, 2010-06-08 at 14:12 +0100, David Howells wrote:
> Steve Best <sfbest@us.ibm.com> wrote:
>
> > -#define KERNELBASE (0xc000000000000000)
> > +#define KERNELBASE (0xc000000000000000ULL)
>
> Is this the right fix? The code producing the warning is subtracting
> 0xc000000000000000 from a 32-bit number:
agree this fix needs more work, and can be dropped. Paul has another
patch that removes this file, since it is no longer used. I assume we'll
go with that patch.
>
> naca = ntohl(*((u_int32_t*) &inbuf[0x0C])) - KERNELBASE;
>
> which seems distinctly odd.
>
> David
-Steve
prev parent reply other threads:[~2010-06-09 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 20:49 [PATCH] powerpc: Fix integer constant warning Steve Best
2010-06-08 13:12 ` David Howells
2010-06-08 13:55 ` Josh Boyer
2010-06-08 14:23 ` David Howells
2010-06-09 11:50 ` Steve Best [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276084207.6135.11.camel@localhost.localdomain \
--to=sfbest@us.ibm.com \
--cc=dhowells@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).