From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 280711007D7 for ; Fri, 11 Jun 2010 11:16:47 +1000 (EST) Subject: Re: [PATCH 0/2] Replace of_device with platform_device From: Benjamin Herrenschmidt To: Grant Likely In-Reply-To: References: <20100604205930.2762.17131.stgit@angua> <1276151543.1962.48.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 11 Jun 2010 11:16:30 +1000 Message-ID: <1276218990.1962.81.camel@pasglop> Mime-Version: 1.0 Cc: Stephen Rothwell , Michal Simek , microblaze-uclinux@itee.uq.edu.au, linuxppc-dev , sparclinux@vger.kernel.org, David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2010-06-10 at 10:46 -0600, Grant Likely wrote: > > It shouldn't need any fixing because I'm not touching the driver side > of the equation (unlike the last breakage where macio_driver had its > own copy of the match table which I missed). In fact, there aren't > even any logic changes other than dealing with moving some of the > structure members in the sparc arch code. If I did miss anything, > then it should show up in build testing. Ok, but I though you were actually replacing occurences of "of_device" with "platform_device", and so was wondering why you aren't changing the ones in macio. But yes, the #define you did might do the trick as long as the resources are still named the same etc... Cheers, Ben.