* [PATCH] Add cmd64x IDE driver to default pmac32 config
@ 2010-07-03 18:21 lawrence rust
2010-07-08 5:00 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: lawrence rust @ 2010-07-03 18:21 UTC (permalink / raw)
To: linuxppc-dev
The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible
IDE disk controller. E.g. lspci shows...
01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)
Unfortunately the default pmac32 configuration does not include this
driver and so PowerMac G3's can't load a root filesystem. This is an
issue on a least Ubuntu since version 9.04, which uses the default
config as a starting point.
Signed-off-by: Lawrence Rust <lawrence at softsystem.co.uk>
diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
--- a/arch/powerpc/configs/pmac32_defconfig 2010-05-16 23:17:36.000000000 +0200
+++ b/arch/powerpc/configs/pmac32_defconfig 2010-07-03 20:11:10.000000000 +0200
@@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
# CONFIG_BLK_DEV_AEC62XX is not set
# CONFIG_BLK_DEV_ALI15X3 is not set
# CONFIG_BLK_DEV_AMD74XX is not set
-# CONFIG_BLK_DEV_CMD64X is not set
+CONFIG_BLK_DEV_CMD64X=y
# CONFIG_BLK_DEV_TRIFLEX is not set
# CONFIG_BLK_DEV_CS5520 is not set
# CONFIG_BLK_DEV_CS5530 is not set
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
2010-07-03 18:21 [PATCH] Add cmd64x IDE driver to default pmac32 config lawrence rust
@ 2010-07-08 5:00 ` Benjamin Herrenschmidt
2010-07-08 6:18 ` lawrence rust
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-08 5:00 UTC (permalink / raw)
To: lawrence rust; +Cc: linuxppc-dev
On Sat, 2010-07-03 at 20:21 +0200, lawrence rust wrote:
> The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible
> IDE disk controller. E.g. lspci shows...
>
> 01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)
>
> Unfortunately the default pmac32 configuration does not include this
> driver and so PowerMac G3's can't load a root filesystem. This is an
> issue on a least Ubuntu since version 9.04, which uses the default
> config as a starting point.
>
> Signed-off-by: Lawrence Rust <lawrence at softsystem.co.uk>
Shouldn't we just switch the whole thing to libata now anyways ?
Cheers,
Ben.
> diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
> --- a/arch/powerpc/configs/pmac32_defconfig 2010-05-16 23:17:36.000000000 +0200
> +++ b/arch/powerpc/configs/pmac32_defconfig 2010-07-03 20:11:10.000000000 +0200
> @@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
> # CONFIG_BLK_DEV_AEC62XX is not set
> # CONFIG_BLK_DEV_ALI15X3 is not set
> # CONFIG_BLK_DEV_AMD74XX is not set
> -# CONFIG_BLK_DEV_CMD64X is not set
> +CONFIG_BLK_DEV_CMD64X=y
> # CONFIG_BLK_DEV_TRIFLEX is not set
> # CONFIG_BLK_DEV_CS5520 is not set
> # CONFIG_BLK_DEV_CS5530 is not set
>
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
2010-07-08 5:00 ` Benjamin Herrenschmidt
@ 2010-07-08 6:18 ` lawrence rust
2010-07-08 6:30 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: lawrence rust @ 2010-07-08 6:18 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Thu, 2010-07-08 at 15:00 +1000, Benjamin Herrenschmidt wrote:
> On Sat, 2010-07-03 at 20:21 +0200, lawrence rust wrote:
> > The Blue/White Apple PowerMac G3 and early G4's use a cmd64x compatible
> > IDE disk controller. E.g. lspci shows...
> >
> > 01:01.0 IDE interface: Silicon Image, Inc. PCI0646 (rev 07)
> >
> > Unfortunately the default pmac32 configuration does not include this
> > driver and so PowerMac G3's can't load a root filesystem. This is an
> > issue on a least Ubuntu since version 9.04, which uses the default
> > config as a starting point.
> >
> > Signed-off-by: Lawrence Rust <lawrence at softsystem.co.uk>
>
> Shouldn't we just switch the whole thing to libata now anyways ?
Sure. it would be preferable but unfortunately the PowerMac on-board IDE
controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W
G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE
code is removed) to use the IDE cmd64x driver to minimise kernel code
size.
A minor correction to my previous post, the first version of Ubuntu to
suffer from this problem was 9.10.
-- Lawrence
>
> Cheers,
> Ben.
>
> > diff -uprN a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
> > --- a/arch/powerpc/configs/pmac32_defconfig 2010-05-16 23:17:36.000000000 +0200
> > +++ b/arch/powerpc/configs/pmac32_defconfig 2010-07-03 20:11:10.000000000 +0200
> > @@ -738,7 +738,7 @@ CONFIG_BLK_DEV_IDEDMA_PCI=y
> > # CONFIG_BLK_DEV_AEC62XX is not set
> > # CONFIG_BLK_DEV_ALI15X3 is not set
> > # CONFIG_BLK_DEV_AMD74XX is not set
> > -# CONFIG_BLK_DEV_CMD64X is not set
> > +CONFIG_BLK_DEV_CMD64X=y
> > # CONFIG_BLK_DEV_TRIFLEX is not set
> > # CONFIG_BLK_DEV_CS5520 is not set
> > # CONFIG_BLK_DEV_CS5530 is not set
> >
> >
> >
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
>
>
--
-- Lawrence Rust
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
2010-07-08 6:18 ` lawrence rust
@ 2010-07-08 6:30 ` Benjamin Herrenschmidt
2010-07-08 9:01 ` lawrence rust
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-08 6:30 UTC (permalink / raw)
To: lawrence rust; +Cc: linuxppc-dev
On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote:
>
> Sure. it would be preferable but unfortunately the PowerMac on-board IDE
> controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W
> G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE
> code is removed) to use the IDE cmd64x driver to minimise kernel code
> size.
Sure it does nowadays: drivers/ata/pata_macio.c :-)
I merged that upstream in december last year, so it didn't make 2.6.32
which your distro probably uses, but it is in .33 and later.
> A minor correction to my previous post, the first version of Ubuntu to
> suffer from this problem was 9.10.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
2010-07-08 6:30 ` Benjamin Herrenschmidt
@ 2010-07-08 9:01 ` lawrence rust
2010-07-08 10:49 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: lawrence rust @ 2010-07-08 9:01 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Thu, 2010-07-08 at 16:30 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote:
> >
> > Sure. it would be preferable but unfortunately the PowerMac on-board IDE
> > controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W
> > G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE
> > code is removed) to use the IDE cmd64x driver to minimise kernel code
> > size.
>
> Sure it does nowadays: drivers/ata/pata_macio.c :-)
>
> I merged that upstream in december last year, so it didn't make 2.6.32
> which your distro probably uses, but it is in .33 and later.
OK I see that - good news. However, for the moment I believe that it's
safer to stay with IDE. It's the smallest of changes but the wholesale
move to libata could well break numerous system install scripts - e.g.
for yaboot.
-- Lawrence
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
2010-07-08 9:01 ` lawrence rust
@ 2010-07-08 10:49 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2010-07-08 10:49 UTC (permalink / raw)
To: lawrence rust; +Cc: linuxppc-dev
On Thu, 2010-07-08 at 11:01 +0200, lawrence rust wrote:
> On Thu, 2010-07-08 at 16:30 +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote:
> > >
> > > Sure. it would be preferable but unfortunately the PowerMac on-board IDE
> > > controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W
> > > G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE
> > > code is removed) to use the IDE cmd64x driver to minimise kernel code
> > > size.
> >
> > Sure it does nowadays: drivers/ata/pata_macio.c :-)
> >
> > I merged that upstream in december last year, so it didn't make 2.6.32
> > which your distro probably uses, but it is in .33 and later.
>
> OK I see that - good news. However, for the moment I believe that it's
> safer to stay with IDE. It's the smallest of changes but the wholesale
> move to libata could well break numerous system install scripts - e.g.
> for yaboot.
Well, distros have moved over mostly... I don't think keeping the
defaults to the old stuff upstream is going to help getting things like
yaboot fixed. I'll talk to Tony see what the situation there is
tomorrow, but I'd rather fix yaboot and switch the default over.
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-08 10:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 18:21 [PATCH] Add cmd64x IDE driver to default pmac32 config lawrence rust
2010-07-08 5:00 ` Benjamin Herrenschmidt
2010-07-08 6:18 ` lawrence rust
2010-07-08 6:30 ` Benjamin Herrenschmidt
2010-07-08 9:01 ` lawrence rust
2010-07-08 10:49 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).