From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: lawrence rust <lawrence@softsystem.co.uk>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] Add cmd64x IDE driver to default pmac32 config
Date: Thu, 08 Jul 2010 20:49:14 +1000 [thread overview]
Message-ID: <1278586154.28659.93.camel@pasglop> (raw)
In-Reply-To: <1278579667.2850.5.camel@gagarin>
On Thu, 2010-07-08 at 11:01 +0200, lawrence rust wrote:
> On Thu, 2010-07-08 at 16:30 +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2010-07-08 at 08:18 +0200, lawrence rust wrote:
> > >
> > > Sure. it would be preferable but unfortunately the PowerMac on-board IDE
> > > controller (CONFIG_BLK_DEV_IDE_PMAC), used for the DVD drive on B/W
> > > G3's, doesn't have a PATA equivalent. So it's pragmatic (until the IDE
> > > code is removed) to use the IDE cmd64x driver to minimise kernel code
> > > size.
> >
> > Sure it does nowadays: drivers/ata/pata_macio.c :-)
> >
> > I merged that upstream in december last year, so it didn't make 2.6.32
> > which your distro probably uses, but it is in .33 and later.
>
> OK I see that - good news. However, for the moment I believe that it's
> safer to stay with IDE. It's the smallest of changes but the wholesale
> move to libata could well break numerous system install scripts - e.g.
> for yaboot.
Well, distros have moved over mostly... I don't think keeping the
defaults to the old stuff upstream is going to help getting things like
yaboot fixed. I'll talk to Tony see what the situation there is
tomorrow, but I'd rather fix yaboot and switch the default over.
Ben.
prev parent reply other threads:[~2010-07-08 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 18:21 [PATCH] Add cmd64x IDE driver to default pmac32 config lawrence rust
2010-07-08 5:00 ` Benjamin Herrenschmidt
2010-07-08 6:18 ` lawrence rust
2010-07-08 6:30 ` Benjamin Herrenschmidt
2010-07-08 9:01 ` lawrence rust
2010-07-08 10:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278586154.28659.93.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=lawrence@softsystem.co.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).