From: Mingkai Hu <Mingkai.hu@freescale.com>
To: linuxppc-dev@ozlabs.org
Cc: Mingkai Hu <Mingkai.hu@freescale.com>
Subject: [PATCH 4/6] mtd: m25p80: change the read function to read page by page
Date: Tue, 20 Jul 2010 10:08:23 +0800 [thread overview]
Message-ID: <1279591705-7574-5-git-send-email-Mingkai.hu@freescale.com> (raw)
In-Reply-To: <1279591705-7574-4-git-send-email-Mingkai.hu@freescale.com>
For Freescale's eSPI controller, the max transaction length one time
is limitted by the SPCOM[TRANSLEN] field which is 0x10000. When used
mkfs.ext2 command to create ext2 filesystem on the flash, the read
length will exceed the max value of the SPCOM[TRANSLEN] field, so
change the read function to read page by page.
For other SPI flash driver, also needed to change the read function
if used the eSPI controller.
Signed-off-by: Mingkai Hu <Mingkai.hu@freescale.com>
---
drivers/mtd/devices/m25p80.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 81e49a9..6cbe6b1 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -317,6 +317,7 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
struct m25p *flash = mtd_to_m25p(mtd);
struct spi_transfer t[2];
struct spi_message m;
+ u32 i, page_size = 0;
DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
dev_name(&flash->spi->dev), __func__, "from",
@@ -341,7 +342,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
spi_message_add_tail(&t[0], &m);
t[1].rx_buf = buf;
- t[1].len = len;
spi_message_add_tail(&t[1], &m);
/* Byte count starts at zero. */
@@ -364,11 +364,21 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
/* Set up the write data buffer. */
flash->command[0] = OPCODE_READ;
- m25p_addr2cmd(flash, from, flash->command);
- spi_sync(flash->spi, &m);
+ for (i = page_size; i < len; i += page_size) {
+ page_size = len - i;
+ if (page_size > flash->page_size)
+ page_size = flash->page_size;
- *retlen = m.actual_length - m25p_cmdsz(flash) - FAST_READ_DUMMY_BYTE;
+ m25p_addr2cmd(flash, from + i, flash->command);
+ t[1].len = page_size;
+ t[1].rx_buf = buf + i;
+
+ spi_sync(flash->spi, &m);
+
+ *retlen += m.actual_length - m25p_cmdsz(flash)
+ - FAST_READ_DUMMY_BYTE;
+ }
mutex_unlock(&flash->lock);
--
1.6.4
next prev parent reply other threads:[~2010-07-20 2:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 2:08 [PATCH 0/6] refactor spi_mpc8xxx.c and add eSPI controller support Mingkai Hu
2010-07-20 2:08 ` [PATCH 1/6] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Mingkai Hu
2010-07-20 2:08 ` [PATCH 2/6] eSPI: add eSPI controller support Mingkai Hu
2010-07-20 2:08 ` [PATCH 3/6] of/spi: add support to parse the SPI flash's partitions Mingkai Hu
2010-07-20 2:08 ` Mingkai Hu [this message]
2010-07-20 2:08 ` [PATCH 5/6] powerpc/of: add eSPI controller dts bindings Mingkai Hu
2010-07-20 2:08 ` [PATCH 6/6] DTS: add SPI flash(s25fl128p01) support on p4080ds and mpc8536ds board Mingkai Hu
2010-07-26 0:35 ` Grant Likely
2010-07-26 7:39 ` Hu Mingkai-B21284
2010-07-26 7:59 ` Grant Likely
2010-07-26 0:33 ` [PATCH 5/6] powerpc/of: add eSPI controller dts bindings Grant Likely
2010-07-26 7:35 ` Hu Mingkai-B21284
2010-07-26 0:30 ` [PATCH 4/6] mtd: m25p80: change the read function to read page by page Grant Likely
2010-07-26 7:33 ` Hu Mingkai-B21284
2010-07-26 7:55 ` Grant Likely
2010-07-26 0:28 ` [PATCH 3/6] of/spi: add support to parse the SPI flash's partitions Grant Likely
2010-07-26 7:25 ` Hu Mingkai-B21284
2010-07-26 7:52 ` Grant Likely
2010-07-26 8:20 ` Hu Mingkai-B21284
2010-07-27 19:24 ` Grant Likely
2010-07-26 0:25 ` [PATCH 2/6] eSPI: add eSPI controller support Grant Likely
2010-07-26 7:02 ` Hu Mingkai-B21284
2010-07-26 0:14 ` [PATCH 1/6] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Grant Likely
2010-07-26 6:18 ` Hu Mingkai-B21284
2010-07-26 6:48 ` Grant Likely
2010-07-26 7:07 ` Zang Roy-R61911
2010-07-26 7:45 ` Grant Likely
2010-07-26 0:36 ` [PATCH 0/6] refactor spi_mpc8xxx.c and add eSPI controller support Grant Likely
2010-07-26 5:52 ` Hu Mingkai-B21284
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279591705-7574-5-git-send-email-Mingkai.hu@freescale.com \
--to=mingkai.hu@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).