From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] Adjust arch/powerpc inline asms for recent gcc change
Date: Fri, 30 Jul 2010 17:52:12 +1000 [thread overview]
Message-ID: <1280476332.2169.4.camel@pasglop> (raw)
In-Reply-To: <20100730071922.GQ18378@tyan-ft48-01.lab.bos.redhat.com>
On Fri, 2010-07-30 at 09:19 +0200, Jakub Jelinek wrote:
> So, in short, I'm afraid "m<>" needs to be used only for GCC 4.6+
> (and, vendors which backported the inline-asm handling changes
> to their older gcc would need to adjust for their gccs too).
> When "m<>" isn't used, it just leads to potential code pessimization
> in inline-asms that are prepared for handling side-effects.
Ok, so we'll need some kind of macro to "fixup" those constraints ...
Just to make sure I understand things properly, if we don't change them,
the code will still be correct with 4.6 but sub-optimal, right ?
Cheers,
Ben.
prev parent reply other threads:[~2010-07-30 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 9:56 [PATCH] Adjust arch/powerpc inline asms for recent gcc change Jakub Jelinek
2010-06-25 11:08 ` Segher Boessenkool
2010-06-25 11:18 ` Jakub Jelinek
2010-06-30 6:10 ` Benjamin Herrenschmidt
2010-06-30 22:26 ` Segher Boessenkool
2010-07-08 6:08 ` Benjamin Herrenschmidt
2010-07-30 7:04 ` Benjamin Herrenschmidt
2010-07-30 7:19 ` Jakub Jelinek
2010-07-30 7:52 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280476332.2169.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jakub@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).