From: Matthew McClintock <msm@freescale.com>
To: kexec@lists.infradead.org
Cc: muvarov@gmail.com, linuxppc-dev@ozlabs.org,
Kumar Gala <kumar.gala@freescale.com>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Matthew McClintock <msm@freescale.com>
Subject: [PATCH v2 3/3] Prevent initrd-start and initrd-end from appearing multiple times
Date: Wed, 18 Aug 2010 23:56:51 -0500 [thread overview]
Message-ID: <1282193811-23098-4-git-send-email-msm@freescale.com> (raw)
In-Reply-To: <20100819042023.GC13965@verge.net.au>
We always remove the old entry, and add it back if it is needed
on for the kexec'ed kernel
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
kexec/arch/ppc/fixup_dtb.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/kexec/arch/ppc/fixup_dtb.c b/kexec/arch/ppc/fixup_dtb.c
index 910a3f0..205fd77 100644
--- a/kexec/arch/ppc/fixup_dtb.c
+++ b/kexec/arch/ppc/fixup_dtb.c
@@ -160,7 +160,7 @@ static void fixup_reserve_regions(struct kexec_info *info, char *blob_buf, off_t
goto out;
}
}
- } else {
+ } else if (ramdisk || reuse_initrd) {
/* Otherwise we just add back the ramdisk and the device tree
* is already in the list */
ret = fdt_add_mem_rsv(blob_buf, ramdisk_base, ramdisk_size);
@@ -300,13 +300,16 @@ static void fixup_initrd(char *blob_buf)
nodeoffset = fdt_path_offset(blob_buf, "/chosen");
- if ((reuse_initrd || ramdisk) &&
- ((ramdisk_base != 0) && (ramdisk_size != 0))) {
- if (nodeoffset < 0) {
- printf("fdt_initrd: %s\n", fdt_strerror(nodeoffset));
- return;
- }
+ if (nodeoffset < 0) {
+ printf("fdt_initrd: %s\n", fdt_strerror(nodeoffset));
+ return;
+ }
+
+ fdt_delprop(blob_buf, nodeoffset, "linux,initrd-start");
+ fdt_delprop(blob_buf, nodeoffset, "linux,initrd-end");
+ if ((reuse_initrd || ramdisk) &&
+ ((ramdisk_base != 0) && (ramdisk_size != 0))) {
tmp = ramdisk_base;
err = fdt_setprop(blob_buf, nodeoffset,
"linux,initrd-start", &tmp, sizeof(tmp));
@@ -325,9 +328,6 @@ static void fixup_initrd(char *blob_buf)
fdt_strerror(err));
return;
}
- } else {
- fdt_delprop(blob_buf, nodeoffset, "linux,initrd-start");
- fdt_delprop(blob_buf, nodeoffset, "linux,initrd-end");
}
}
--
1.6.0.6
prev parent reply other threads:[~2010-08-19 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100819042023.GC13965@verge.net.au>
2010-08-19 4:56 ` [PATCH v2 0/3] Misc. bug fixes for ppc32 Matthew McClintock
2010-08-20 8:27 ` Simon Horman
2010-08-19 4:56 ` [PATCH v2 1/3] Ramdisk address was not copied correctly on kexec'ed kernel Matthew McClintock
2010-08-19 4:56 ` [PATCH v2 2/3] Prevent multiple reservations for cpu-release-addr Matthew McClintock
2010-08-19 4:56 ` Matthew McClintock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282193811-23098-4-git-send-email-msm@freescale.com \
--to=msm@freescale.com \
--cc=kexec@lists.infradead.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=muvarov@gmail.com \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).