From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
paulus@au.ibm.com, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/2] rwsem: Move powerpc atomic-long based implementation to asm-generic
Date: Tue, 24 Aug 2010 11:32:05 +1000 [thread overview]
Message-ID: <1282613525.22370.486.camel@pasglop> (raw)
In-Reply-To: <20100820064348.GA19989@merkur.ravnborg.org>
On Fri, 2010-08-20 at 08:43 +0200, Sam Ravnborg wrote:
> > diff --git a/include/asm-generic/rwsem-cmpxchg.h b/include/asm-generic/rwsem-cmpxchg.h
> > new file mode 100644
> > index 0000000..2b1c859
> > --- /dev/null
> > +++ b/include/asm-generic/rwsem-cmpxchg.h
> > @@ -0,0 +1,183 @@
> > +#ifndef _RWSEM_CMPXCHG_H
> > +#define _RWSEM_CMPXCHG_H
> > +
> > +#ifndef _LINUX_RWSEM_H
> > +#error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead."
> > +#endif
> > +
> > +#ifdef __KERNEL__
>
> #ifdef __KERNEL__ is only relevant for exported headers.
> For kernel only headers like this is does not make sense,
> but it does not harm.
Well, it was there in the first place, I think we've carried around
forever, but as you say, it doesn't really harm.
Ben.
next prev parent reply other threads:[~2010-08-24 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100817.180325.104051399.davem@davemloft.net>
[not found] ` <AANLkTikQ1dGw0aO10_ZwmVEc-JAVhB==3HS7SrWycE49@mail.gmail.com>
[not found] ` <AANLkTimZ3rhX2AzPExEGfRCXiFNN-BGOWRKqL241-qNa@mail.gmail.com>
[not found] ` <20100817.191424.183031381.davem@davemloft.net>
2010-08-18 4:38 ` 64-bit ppc rwsem (was: Re: [GIT] Sparc) Benjamin Herrenschmidt
2010-08-18 5:03 ` Benjamin Herrenschmidt
2010-08-18 5:28 ` 64-bit ppc rwsem David Miller
2010-08-18 5:39 ` Sam Ravnborg
2010-08-18 5:48 ` David Miller
2010-08-19 5:23 ` Benjamin Herrenschmidt
2010-08-19 5:29 ` David Miller
2010-08-19 10:24 ` Benjamin Herrenschmidt
2010-08-20 5:14 ` [PATCH 1/2] powerpc: Make rwsem use "long" type Benjamin Herrenschmidt
2010-08-24 1:37 ` Timur Tabi
2010-08-20 5:14 ` [PATCH 2/2] rwsem: Move powerpc atomic-long based implementation to asm-generic Benjamin Herrenschmidt
2010-08-20 6:43 ` Sam Ravnborg
2010-08-24 1:32 ` Benjamin Herrenschmidt [this message]
2010-08-23 4:39 ` David Miller
2010-08-23 13:44 ` 64-bit ppc rwsem Arnd Bergmann
2010-08-23 22:01 ` Benjamin Herrenschmidt
2010-08-23 22:18 ` David Miller
2010-08-24 1:31 ` Benjamin Herrenschmidt
2010-08-24 12:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282613525.22370.486.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@au.ibm.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).