* [PATCH] powerpc/512x: fix clk_get() return value
@ 2010-08-31 8:43 Akinobu Mita
2010-09-01 15:32 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2010-08-31 8:43 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Akinobu Mita
clk_get() should return an ERR_PTR value on error, not NULL.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/platforms/512x/clock.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/512x/clock.c b/arch/powerpc/platforms/512x/clock.c
index 5b243bd..3dc2a8d 100644
--- a/arch/powerpc/platforms/512x/clock.c
+++ b/arch/powerpc/platforms/512x/clock.c
@@ -57,7 +57,7 @@ static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
int id_match = 0;
if (dev == NULL || id == NULL)
- return NULL;
+ return clk;
mutex_lock(&clocks_mutex);
list_for_each_entry(p, &clocks, node) {
--
1.7.1.231.gd0b16
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/512x: fix clk_get() return value
2010-08-31 8:43 [PATCH] powerpc/512x: fix clk_get() return value Akinobu Mita
@ 2010-09-01 15:32 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2010-09-01 15:32 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linuxppc-dev
On Tue, Aug 31, 2010 at 05:43:51PM +0900, Akinobu Mita wrote:
> clk_get() should return an ERR_PTR value on error, not NULL.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: linuxppc-dev@lists.ozlabs.org
applied, thanks.
g.
> ---
> arch/powerpc/platforms/512x/clock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/512x/clock.c b/arch/powerpc/platforms/512x/clock.c
> index 5b243bd..3dc2a8d 100644
> --- a/arch/powerpc/platforms/512x/clock.c
> +++ b/arch/powerpc/platforms/512x/clock.c
> @@ -57,7 +57,7 @@ static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
> int id_match = 0;
>
> if (dev == NULL || id == NULL)
> - return NULL;
> + return clk;
>
> mutex_lock(&clocks_mutex);
> list_for_each_entry(p, &clocks, node) {
> --
> 1.7.1.231.gd0b16
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-01 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-31 8:43 [PATCH] powerpc/512x: fix clk_get() return value Akinobu Mita
2010-09-01 15:32 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).