From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia@diku.dk>
Cc: cbe-oss-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: question about arch/powerpc/platforms/cell/celleb_scc_uhc.c
Date: Wed, 01 Sep 2010 09:02:30 -0700 [thread overview]
Message-ID: <1283356950.1797.159.camel@Joe-Laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.1009011748050.32566@ask.diku.dk>
On Wed, 2010-09-01 at 17:51 +0200, Julia Lawall wrote:
> The file arch/powerpc/platforms/cell/celleb_scc_uhc.c contains the
> following function:
> static inline int uhc_clkctrl_ready(u32 val)
> {
> const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
> return((val & mask) == mask);
> }
> The variable mask is a bit or of two identical constants. Later in the
> same file in the function enable_scc_uhc, I see the code:
> val |= (SCC_UHC_USBCEN | SCC_UHC_USBEN);
> Should the code in uhc_clkctrl_ready also be SCC_UHC_USBCEN | SCC_UHC_USBEN?
> Or something else?
Thanks Julia.
This was also noticed a couple of years ago and not applied
http://lkml.indiana.edu/hypermail/linux/kernel/0808.2/1428.html
One day...
next prev parent reply other threads:[~2010-09-01 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 15:51 question about arch/powerpc/platforms/cell/celleb_scc_uhc.c Julia Lawall
2010-09-01 16:02 ` Joe Perches [this message]
2010-09-01 16:05 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283356950.1797.159.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=julia@diku.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox