* linux-next: build failure after merge of the final tree (powerpc related)
@ 2010-09-03 3:24 Stephen Rothwell
2010-09-17 4:27 ` Stephen Rothwell
2010-09-17 7:05 ` [PATCH] powerpc: define a compat_sys_recv cond_syscall Ian Munsie
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2010-09-03 3:24 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev
Cc: linux-next, linux-kernel, Ian Munsie
Hi all,
After merging the final tree, today's linux-next build
(powerpc64 allnoconfig) failed like this:
arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
(.text+0x8d48): undefined reference to `.compat_sys_recv'
Caused by commit 86250b9d12caa1a3dee12a7cf638b7dd70eaadb6 ("powerpc: Wire
up direct socket system calls").
I have applied this patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 3 Sep 2010 13:19:04 +1000
Subject: [PATCH] powerpc: define a compat_sys_recv cond_syscall
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
kernel/sys_ni.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index bad369e..c782fe9 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -50,6 +50,7 @@ cond_syscall(compat_sys_sendmsg);
cond_syscall(sys_recvmsg);
cond_syscall(sys_recvmmsg);
cond_syscall(compat_sys_recvmsg);
+cond_syscall(compat_sys_recv);
cond_syscall(compat_sys_recvfrom);
cond_syscall(compat_sys_recvmmsg);
cond_syscall(sys_socketcall);
--
1.7.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: linux-next: build failure after merge of the final tree (powerpc related)
2010-09-03 3:24 linux-next: build failure after merge of the final tree (powerpc related) Stephen Rothwell
@ 2010-09-17 4:27 ` Stephen Rothwell
2010-09-17 7:05 ` [PATCH] powerpc: define a compat_sys_recv cond_syscall Ian Munsie
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2010-09-17 4:27 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev
Cc: linux-next, linux-kernel, Ian Munsie
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
Hi Ben,
On Fri, 3 Sep 2010 13:24:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build
> (powerpc64 allnoconfig) failed like this:
>
> arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
> (.text+0x8d48): undefined reference to `.compat_sys_recv'
>
> Caused by commit 86250b9d12caa1a3dee12a7cf638b7dd70eaadb6 ("powerpc: Wire
> up direct socket system calls").
>
> I have applied this patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 3 Sep 2010 13:19:04 +1000
> Subject: [PATCH] powerpc: define a compat_sys_recv cond_syscall
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> kernel/sys_ni.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index bad369e..c782fe9 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -50,6 +50,7 @@ cond_syscall(compat_sys_sendmsg);
> cond_syscall(sys_recvmsg);
> cond_syscall(sys_recvmmsg);
> cond_syscall(compat_sys_recvmsg);
> +cond_syscall(compat_sys_recv);
> cond_syscall(compat_sys_recvfrom);
> cond_syscall(compat_sys_recvmmsg);
> cond_syscall(sys_socketcall);
> --
> 1.7.1
Ping?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] powerpc: define a compat_sys_recv cond_syscall
2010-09-03 3:24 linux-next: build failure after merge of the final tree (powerpc related) Stephen Rothwell
2010-09-17 4:27 ` Stephen Rothwell
@ 2010-09-17 7:05 ` Ian Munsie
1 sibling, 0 replies; 3+ messages in thread
From: Ian Munsie @ 2010-09-17 7:05 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Stephen Rothwell, linux-kernel, Eric Paris, linux-next,
Paul Mackerras, Ian Munsie, Russell King, Andrew Morton,
linuxppc-dev, David S. Miller, Eric W. Biederman
From: Stephen Rothwell <sfr@canb.auug.org.au>
Since compat_sys_recv is an optionl syscall if the kernel is compiled
without networking we need a cond_syscall defined for it since it is now
wired up directly on PowerPC.
Other architectures that wire up the socket calls directly as syscalls
do not run into this issue either because they don't have to deal with
the 32bit compat versions of the syscalls or just don't wire up that
particular compat syscall directly.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
---
kernel/sys_ni.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index bad369e..c782fe9 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -50,6 +50,7 @@ cond_syscall(compat_sys_sendmsg);
cond_syscall(sys_recvmsg);
cond_syscall(sys_recvmmsg);
cond_syscall(compat_sys_recvmsg);
+cond_syscall(compat_sys_recv);
cond_syscall(compat_sys_recvfrom);
cond_syscall(compat_sys_recvmmsg);
cond_syscall(sys_socketcall);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-17 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 3:24 linux-next: build failure after merge of the final tree (powerpc related) Stephen Rothwell
2010-09-17 4:27 ` Stephen Rothwell
2010-09-17 7:05 ` [PATCH] powerpc: define a compat_sys_recv cond_syscall Ian Munsie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).