From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Tabi Timur-B04825 <B04825@freescale.com>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: export ppc_tb_freq so that modules can reference it
Date: Sun, 19 Sep 2010 12:42:53 +1000 [thread overview]
Message-ID: <1284864173.30449.111.camel@pasglop> (raw)
In-Reply-To: <70810686-1EB6-4AD9-A89B-C2A8BA6AC30D@freescale.com>
On Sat, 2010-09-18 at 10:34 -0500, Kumar Gala wrote:
> On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote:
>
> > On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt" <benh@kernel.crashing.org> wrote:
> >
> >> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote:
> >>> I don't see any reason to limit it to GPL drivers. Not only that, but
> >>> then we'll have this:
> >>
> >> I do
> >
> > Can you elaborate on that, or are you just going to pull rank on me?
> >
> >>
> >>> EXPORT_SYMBOL(ppc_proc_freq);
> >>> EXPORT_SYMBOL_GPL(ppc_tb_freq);
> >>>
> >>> That just looks dumb.
> >>
> >> Right, so send a patch to fix the first one too :-)
>
> I don't think either of these should be EXPORT_SYMBOL_GPL. Why
> shouldn't a binary module be allowed to know these frequencies? My
> view is why preclude anyone from using this how they want. If they
> want to live in the gray area so be it. Who am I to say they
> shouldn't have that choice.
Well, I'm all for making binary modules life as hard as possible just
for the sake of it :-)
Cheers,
Ben.
prev parent reply other threads:[~2010-09-19 2:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 22:53 [PATCH 1/2] powerpc: export ppc_tb_freq so that modules can reference it Timur Tabi
2010-09-17 22:53 ` [PATCH 2/2] powerpc/watchdog: allow the e500 watchdog driver to be compiled as a module Timur Tabi
2010-09-18 0:37 ` Josh Boyer
2010-09-20 15:51 ` Timur Tabi
2010-09-20 19:30 ` Josh Boyer
2010-09-20 19:53 ` Timur Tabi
2010-09-18 0:38 ` [PATCH 1/2] powerpc: export ppc_tb_freq so that modules can reference it Josh Boyer
2010-09-18 1:20 ` Timur Tabi
2010-09-18 3:14 ` Benjamin Herrenschmidt
2010-09-18 14:36 ` Tabi Timur-B04825
2010-09-18 15:34 ` Kumar Gala
2010-09-18 15:52 ` Vitaly Wool
2010-09-18 16:56 ` Josh Boyer
2010-09-18 17:36 ` Tabi Timur-B04825
2010-09-18 17:46 ` Josh Boyer
2010-09-18 17:55 ` Tabi Timur-B04825
2010-09-18 18:22 ` Josh Boyer
2010-09-20 18:51 ` Scott Wood
[not found] ` <20100920135136.04ceb772__36164.799918379$1285008751$gmane$org@udp111988uds.am.freescale.net>
2010-09-21 12:34 ` Detlev Zundel
2010-09-18 18:36 ` Kumar Gala
2010-09-19 2:42 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284864173.30449.111.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B04825@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).