linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT
Date: Fri, 24 Sep 2010 07:59:17 +1000	[thread overview]
Message-ID: <1285279157.5158.17.camel@pasglop> (raw)
In-Reply-To: <20100923153347.4b517105@udp111988uds.am.freescale.net>

On Thu, 2010-09-23 at 15:33 -0500, Scott Wood wrote:
> I don't see a generic accessor that can test PTE flags for user
> access -- in the absence of one, I guess we need an ifdef here.  Or at
> least put in a comment so anyone who adds a userspace use knows they
> need to fix it. 

We could make up one in powerpc arch at least

#define pte_user(val) ((val & _PAGE_USER) == _PAGE_USER)

would do

Cheers,
Ben.

  reply	other threads:[~2010-09-23 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 20:10 [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT Paul Gortmaker
2010-09-23 20:33 ` Scott Wood
2010-09-23 21:59   ` Benjamin Herrenschmidt [this message]
2010-09-24  5:04     ` [PATCH] powerpc: Fix invalid page flags in create TLB CAM pathfor PTE_64BIT Chen, Tiejun
2010-09-24 15:02       ` Scott Wood
2010-09-24 16:44     ` [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT Paul Gortmaker
2010-10-07  6:05       ` Kumar Gala
2010-09-24  4:54   ` [PATCH] powerpc: Fix invalid page flags in create TLB CAM pathfor PTE_64BIT Chen, Tiejun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285279157.5158.17.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).