From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Anton Blanchard <anton@samba.org>
Subject: [PATCH 1/1] Add config option for batched hcalls
Date: Fri, 24 Sep 2010 16:44:15 -0500 [thread overview]
Message-ID: <1285364655.3016.25.camel@lexx> (raw)
Add a config option for the (batched) MULTITCE and BULK_REMOVE h-calls.
By default, these options are on and are beneficial for performance and
throughput reasons. If disabled, the code will fall back to using less
optimal TCE and REMOVE hcalls. The ability to easily disable these
options is useful for some of the PREEMPT_RT related investigation and
work occurring on Power.
Signed-off-by: Will Schmidt <will_schmidt@vnet.ibm.com>
cc: Anton Blanchard <anton@samba.org>
cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
index f0e6f28..0b5e6a9 100644
--- a/arch/powerpc/platforms/pseries/Kconfig
+++ b/arch/powerpc/platforms/pseries/Kconfig
@@ -81,3 +81,23 @@ config DTL
which are accessible through a debugfs file.
Say N if you are unsure.
+
+config BULK_REMOVE
+ bool "Enable BULK_REMOVE"
+ depends on PPC_PSERIES
+ default y
+ help
+ Enable the BULK_REMOVE option for the hash page code.
+ This relies on a "hcall-bulk" firmware feature, and
+ should be enabled for performance throughput.
+
+config MULTITCE
+ bool "Enable MultiTCE"
+ depends on PPC_PSERIES
+ default y
+ help
+ Enable the Multi-TCE code, allowing a single hcall to
+ update multiple TCE entries at one time. This relies
+ on a "hcall-multi-tce" firmware feature, and should be
+ enabled for performance throughput.
+
diff --git a/arch/powerpc/platforms/pseries/firmware.c b/arch/powerpc/platforms/pseries/firmware.c
index 0a4d8c..4327064 100644
--- a/arch/powerpc/platforms/pseries/firmware.c
+++ b/arch/powerpc/platforms/pseries/firmware.c
@@ -51,9 +51,13 @@ firmware_features_table[FIRMWARE_MAX_FEATURES] = {
{FW_FEATURE_VIO, "hcall-vio"},
{FW_FEATURE_RDMA, "hcall-rdma"},
{FW_FEATURE_LLAN, "hcall-lLAN"},
+#if defined(CONFIG_BULK_REMOVE)
{FW_FEATURE_BULK_REMOVE, "hcall-bulk"},
+#endif
{FW_FEATURE_XDABR, "hcall-xdabr"},
+#if defined(CONFIG_MULTITCE)
{FW_FEATURE_MULTITCE, "hcall-multi-tce"},
+#endif
{FW_FEATURE_SPLPAR, "hcall-splpar"},
};
/* Build up the firmware features bitmask using the contents of
next reply other threads:[~2010-09-24 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 21:44 Will Schmidt [this message]
2010-09-26 3:49 ` [PATCH 1/1] Add config option for batched hcalls Olof Johansson
2010-09-27 20:06 ` Will Schmidt
2010-09-28 17:02 ` [PATCH 1/1 v2 ] Add kernel parameter to disable " Will Schmidt
2010-09-28 17:52 ` Olof Johansson
2010-09-29 1:33 ` [PATCH 1/1 v3] " Will Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285364655.3016.25.camel@lexx \
--to=will_schmidt@vnet.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).