From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org
Subject: Re: [patch 1/1] powerpc: enable ARCH_DMA_ADDR_T_64BIT with ARCH_PHYS_ADDR_T_64BIT
Date: Sun, 03 Oct 2010 17:20:58 +1100 [thread overview]
Message-ID: <1286086858.2463.289.camel@pasglop> (raw)
In-Reply-To: <20101002190634E.fujita.tomonori@lab.ntt.co.jp>
> Really?
>
> The current dma_addr_t is:
>
> #if defined(__powerpc64__) || defined(CONFIG_PHYS_64BIT)
> typedef u64 dma_addr_t;
> #else
> typedef u32 dma_addr_t;
> #endif
> typedef u64 dma64_addr_t;
-EBRAINFAI ... either I wasn't looking when we changed it or I just
forgot :-) We -used-, I'm pretty sure, to have it always 32-bit :-)
Anyways, doesn't matter. Patch looks good. We can always tweak the
config option if we want to later.
Cheers,
Ben.
>
> I think that this patch doesn't change anything. Or I miss something?
>
> @@ -22,6 +22,9 @@ config WORD_SIZE
> config ARCH_PHYS_ADDR_T_64BIT
> def_bool PPC64 || PHYS_64BIT
>
> +config ARCH_DMA_ADDR_T_64BIT
> + def_bool ARCH_PHYS_ADDR_T_64BIT
> +
> config MMU
> bool
> default y
next prev parent reply other threads:[~2010-10-03 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 21:12 [patch 1/1] powerpc: enable ARCH_DMA_ADDR_T_64BIT with ARCH_PHYS_ADDR_T_64BIT akpm
2010-10-02 1:31 ` Josh Boyer
2010-10-02 3:20 ` Benjamin Herrenschmidt
2010-10-02 10:11 ` FUJITA Tomonori
2010-10-03 6:20 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-20 22:56 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286086858.2463.289.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).