* [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64
@ 2010-10-14 13:55 Kumar Gala
2010-10-14 14:12 ` Grant Likely
2010-10-14 14:47 ` Grant Likely
0 siblings, 2 replies; 4+ messages in thread
From: Kumar Gala @ 2010-10-14 13:55 UTC (permalink / raw)
To: grant.likely; +Cc: linuxppc-dev, spi-devel-general
We get the following when building on ppc64 due to lack of include of
<asm/io.h>:
In file included from drivers/spi/spi_fsl_espi.c:25:0:
drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32'
drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32'
drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap'
drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap'
drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/spi/spi_fsl_lib.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h
index 15aa6c2..281e060 100644
--- a/drivers/spi/spi_fsl_lib.h
+++ b/drivers/spi/spi_fsl_lib.h
@@ -18,6 +18,8 @@
#ifndef __SPI_FSL_LIB_H__
#define __SPI_FSL_LIB_H__
+#include <asm/io.h>
+
/* SPI/eSPI Controller driver's private data. */
struct mpc8xxx_spi {
struct device *dev;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64
2010-10-14 13:55 [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64 Kumar Gala
@ 2010-10-14 14:12 ` Grant Likely
2010-10-14 14:41 ` Kumar Gala
2010-10-14 14:47 ` Grant Likely
1 sibling, 1 reply; 4+ messages in thread
From: Grant Likely @ 2010-10-14 14:12 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, spi-devel-general
On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote:
> We get the following when building on ppc64 due to lack of include of
> <asm/io.h>:
Is this an immediate problem (merge for .36), or is it a linux-next thing?
g.
>
> In file included from drivers/spi/spi_fsl_espi.c:25:0:
> drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
> drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32'
> drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
> drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32'
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
> drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap'
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
> drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap'
> drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/spi/spi_fsl_lib.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h
> index 15aa6c2..281e060 100644
> --- a/drivers/spi/spi_fsl_lib.h
> +++ b/drivers/spi/spi_fsl_lib.h
> @@ -18,6 +18,8 @@
> #ifndef __SPI_FSL_LIB_H__
> #define __SPI_FSL_LIB_H__
>
> +#include <asm/io.h>
> +
> /* SPI/eSPI Controller driver's private data. */
> struct mpc8xxx_spi {
> struct device *dev;
> --
> 1.7.2.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64
2010-10-14 14:12 ` Grant Likely
@ 2010-10-14 14:41 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2010-10-14 14:41 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev, spi-devel-general
On Oct 14, 2010, at 9:12 AM, Grant Likely wrote:
> On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote:
>> We get the following when building on ppc64 due to lack of include of
>> <asm/io.h>:
>
> Is this an immediate problem (merge for .36), or is it a linux-next thing?
>
> g.
.37 / next is fine.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64
2010-10-14 13:55 [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64 Kumar Gala
2010-10-14 14:12 ` Grant Likely
@ 2010-10-14 14:47 ` Grant Likely
1 sibling, 0 replies; 4+ messages in thread
From: Grant Likely @ 2010-10-14 14:47 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, spi-devel-general
On Thu, Oct 14, 2010 at 08:55:47AM -0500, Kumar Gala wrote:
> We get the following when building on ppc64 due to lack of include of
> <asm/io.h>:
Applied.
g.
>
> In file included from drivers/spi/spi_fsl_espi.c:25:0:
> drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
> drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32'
> drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
> drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32'
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
> drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap'
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
> drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap'
> drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> drivers/spi/spi_fsl_lib.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi_fsl_lib.h b/drivers/spi/spi_fsl_lib.h
> index 15aa6c2..281e060 100644
> --- a/drivers/spi/spi_fsl_lib.h
> +++ b/drivers/spi/spi_fsl_lib.h
> @@ -18,6 +18,8 @@
> #ifndef __SPI_FSL_LIB_H__
> #define __SPI_FSL_LIB_H__
>
> +#include <asm/io.h>
> +
> /* SPI/eSPI Controller driver's private data. */
> struct mpc8xxx_spi {
> struct device *dev;
> --
> 1.7.2.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-14 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-14 13:55 [PATCH] spi/fsl_spi: Fix compile errors when building on ppc64 Kumar Gala
2010-10-14 14:12 ` Grant Likely
2010-10-14 14:41 ` Kumar Gala
2010-10-14 14:47 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).